sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 00:53:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock

Browse Source
This commit is contained in:
Dean Herbert
2021-06-28 15:04:14 +09:00
parent 57ae87956a
commit c281e43cd8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Database/RealmContextFactory.cs
View File

@ -97,6 +97,9 @@ namespace osu.Game.Database
{ {
try try
{ {
if (IsDisposed)
throw new InvalidOperationException(@"Attempted to retrieve a context after the factor has already been disposed.");
blockingLock.Wait(); blockingLock.Wait();
contexts_created.Value++; contexts_created.Value++;
@ -128,11 +131,8 @@ namespace osu.Game.Database
{ {
base.Dispose(isDisposing); base.Dispose(isDisposing);
// In the standard case, operations will already be blocked by the Update thread "pausing" from GameHost exit. // intentionally block all operations indefinitely. this ensures that nothing can start consuming a new context after disposal.
// This avoids waiting (forever) on an already entered semaphore. BlockAllOperations();
if (context != null || active_usages.Value > 0)
BlockAllOperations();
blockingLock?.Dispose(); blockingLock?.Dispose();
} }