sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-03 22:56:36 +09:00
Code Issues Packages Projects Releases Wiki Activity

Take type and id from container directly on submit

Browse Source
This commit is contained in:
ansel
2023-01-14 22:57:23 +03:00
parent cdf3aafddd
commit c2bb0949f5
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
osu.Game/Overlays/Comments/CommentsContainer.cs
View File

@ -29,13 +29,10 @@ namespace osu.Game.Overlays.Comments
[Cached]
public partial class CommentsContainer : CompositeDrawable
{
private const string cid = "commentableId";
[Cached]
private readonly Bindable<CommentableType> type = new Bindable<CommentableType>();
[Cached(name: cid)]
private readonly BindableLong id = new BindableLong();
public IBindable<CommentableType> Type => type;
public IBindable<long> Id => id;
public readonly Bindable<CommentsSortCriteria> Sort = new Bindable<CommentsSortCriteria>();
public readonly BindableBool ShowDeleted = new BindableBool();
@ -413,24 +410,23 @@ namespace osu.Game.Overlays.Comments
private partial class NewCommentEditor : CommentEditor
{
[Resolved]
public Bindable<CommentableType> CommentableType { get; set; }
[Resolved(name: cid)]
public BindableLong CommentableId { get; set; }
protected override LocalisableString FooterText => default;
protected override LocalisableString CommitButtonText => CommonStrings.ButtonsPost;
protected override LocalisableString TextBoxPlaceholder => CommentsStrings.PlaceholderNew;
private CommentsContainer commentsContainer { get; set; }
[Resolved]
private IAPIProvider api { get; set; }
public Action<CommentBundle> OnPost;
protected override LocalisableString FooterText => default;
protected override LocalisableString CommitButtonText => CommonStrings.ButtonsPost;
protected override LocalisableString TextBoxPlaceholder => CommentsStrings.PlaceholderNew;
protected override void OnCommit(string text)
{
ShowLoadingSpinner = true;
CommentPostRequest req = new CommentPostRequest(CommentableType.Value, CommentableId.Value, text);
CommentPostRequest req = new CommentPostRequest(commentsContainer.Type.Value, commentsContainer.Id.Value, text);
req.Failure += _ => Schedule(() =>
{
ShowLoadingSpinner = false;