sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-03 06:36:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add required parameters and other various changes

Browse Source
This commit is contained in:
Craftplacer
2020-08-15 22:03:24 +02:00
parent 69590113d6
commit c4a7fac760
8 changed files with 51 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
View File

@ -24,14 +24,14 @@ namespace osu.Game.Beatmaps.Formats
public const int LATEST_VERSION = 128;
private readonly IBeatmap beatmap;
private readonly LegacyBeatmapSkin beatmapSkin;
private readonly ISkin skin;
/// <param name="beatmap">The beatmap to encode</param>
/// <param name="beatmapSkin">An optional beatmap skin, for encoding the beatmap's combo colours.</param>
public LegacyBeatmapEncoder(IBeatmap beatmap, [CanBeNull] LegacyBeatmapSkin beatmapSkin)
/// <param name="skin">An optional skin, for encoding the beatmap's combo colours. This will only work if the parameter is a type of <see cref="LegacyBeatmapSkin"/>.</param>
public LegacyBeatmapEncoder(IBeatmap beatmap, [CanBeNull] ISkin skin)
{
this.beatmap = beatmap;
this.beatmapSkin = beatmapSkin;
this.skin = skin;
if (beatmap.BeatmapInfo.RulesetID < 0 || beatmap.BeatmapInfo.RulesetID > 3)
throw new ArgumentException("Only beatmaps in the osu, taiko, catch, or mania rulesets can be encoded to the legacy beatmap format.", nameof(beatmap));
@ -207,7 +207,10 @@ namespace osu.Game.Beatmaps.Formats
private void handleComboColours(TextWriter writer)
{
var colours = beatmapSkin?.Configuration.ComboColours;
if (!(skin is LegacyBeatmapSkin legacySkin))
return;
var colours = legacySkin?.Configuration.ComboColours;
if (colours == null || colours.Count == 0)
return;