sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-01 19:57:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add explicit todo about removing BeatmapInfo.MaxCombo

Browse Source 
Using that property is a trap basically.
This commit is contained in:
Salman Ahmed 2022-03-20 05:01:32 +03:00
parent d681643c38
commit c5cc7eec79
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Beatmaps/BeatmapInfo.cs
View File

@ -9,6 +9,7 @@ using osu.Framework.Testing;
using osu.Game.Database; using osu.Game.Database;
using osu.Game.Models; using osu.Game.Models;
using osu.Game.Online.API.Requests.Responses; using osu.Game.Online.API.Requests.Responses;
using osu.Game.Overlays.BeatmapSet.Scores;
using osu.Game.Rulesets; using osu.Game.Rulesets;
using osu.Game.Scoring; using osu.Game.Scoring;
using Realms; using Realms;
@ -169,6 +170,10 @@ namespace osu.Game.Beatmaps
[Ignored] [Ignored]
public APIBeatmap? OnlineInfo { get; set; } public APIBeatmap? OnlineInfo { get; set; }
/// <summary>
/// The maximum achievable combo on this beatmap, populated for online info purposes only.
/// Todo: This should never be used nor exist, but is still relied on in <see cref="ScoresContainer.Scores"/> since <see cref="IBeatmapInfo"/> can't be used yet.
/// </summary>
[Ignored] [Ignored]
public int? MaxCombo { get; set; } public int? MaxCombo { get; set; }