sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 08:03:52 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rename method back and add xmldoc

Browse Source
This commit is contained in:
Dean Herbert
2020-10-05 16:24:02 +09:00
parent a69b1636be
commit c622adde7a
3 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSlider.cs
View File

@ -109,9 +109,9 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
} }
} }
public override void StopLoopingSamples() public override void StopAllSamples()
{ {
base.StopLoopingSamples(); base.StopAllSamples();
slidingSample?.Stop(); slidingSample?.Stop();
} }

4
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinner.cs
View File

@ -124,9 +124,9 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
} }
} }
public override void StopLoopingSamples() public override void StopAllSamples()
{ {
base.StopLoopingSamples(); base.StopAllSamples();
spinningSample?.Stop(); spinningSample?.Stop();
} }

7
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -385,9 +385,10 @@ namespace osu.Game.Rulesets.Objects.Drawables
} }
/// <summary> /// <summary>
/// Stops playback of all samples. Automatically called when <see cref="DrawableHitObject{TObject}"/>'s lifetime has been exceeded. /// Stops playback of all relevant samples. Generally only looping samples should be stopped by this, and the rest let to play out.
/// Automatically called when <see cref="DrawableHitObject{TObject}"/>'s lifetime has been exceeded.
/// </summary> /// </summary>
public virtual void StopLoopingSamples() public virtual void StopAllSamples()
{ {
if (Samples?.Looping == true) if (Samples?.Looping == true)
Samples.Stop(); Samples.Stop();
@ -463,7 +464,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
// failsafe to ensure looping samples don't get stuck in a playing state. // failsafe to ensure looping samples don't get stuck in a playing state.
// this could occur in a non-frame-stable context where DrawableHitObjects get killed before a SkinnableSound has the chance to be stopped. // this could occur in a non-frame-stable context where DrawableHitObjects get killed before a SkinnableSound has the chance to be stopped.
StopLoopingSamples(); StopAllSamples();
UpdateResult(false); UpdateResult(false);
} }