Reworking the Ouendan 2 Hidden code AGAIN

Not finished. Will be finished in a later commit.
This commit is contained in:
Roxie Wattz 2021-10-25 14:09:22 -07:00
parent 7a92c7ab7e
commit c9a2c6c031

View File

@ -50,15 +50,15 @@ namespace osu.Game.Rulesets.Osu.Mods
protected override void ApplyIncreasedVisibilityState(DrawableHitObject hitObject, ArmedState state) protected override void ApplyIncreasedVisibilityState(DrawableHitObject hitObject, ArmedState state)
{ {
applyState(hitObject, true); applyHiddenState(hitObject, true, OnlyFadeApproachCircles.Value);
} }
protected override void ApplyNormalVisibilityState(DrawableHitObject hitObject, ArmedState state) protected override void ApplyNormalVisibilityState(DrawableHitObject hitObject, ArmedState state)
{ {
applyState(hitObject, false); applyHiddenState(hitObject, false, OnlyFadeApproachCircles.Value);
} }
private void applyState(DrawableHitObject drawableObject, bool increaseVisibility) private void applyHiddenState(DrawableHitObject drawableObject, bool hideApproachCircle, bool hideCirclePiece)
{ {
if (!(drawableObject is DrawableOsuHitObject drawableOsuObject)) if (!(drawableObject is DrawableOsuHitObject drawableOsuObject))
return; return;
@ -67,8 +67,6 @@ namespace osu.Game.Rulesets.Osu.Mods
(double fadeStartTime, double fadeDuration) = getFadeOutParameters(drawableOsuObject); (double fadeStartTime, double fadeDuration) = getFadeOutParameters(drawableOsuObject);
if (!OnlyFadeApproachCircles.Value)
{
switch (drawableObject) switch (drawableObject)
{ {
case DrawableSliderTail _: case DrawableSliderTail _:
@ -87,7 +85,7 @@ namespace osu.Game.Rulesets.Osu.Mods
case DrawableHitCircle circle: case DrawableHitCircle circle:
Drawable fadeTarget = circle; Drawable fadeTarget = circle;
if (increaseVisibility) if (hideApproachCircle)
{ {
// only fade the circle piece (not the approach circle) for the increased visibility object. // only fade the circle piece (not the approach circle) for the increased visibility object.
fadeTarget = circle.CirclePiece; fadeTarget = circle.CirclePiece;
@ -127,31 +125,6 @@ namespace osu.Game.Rulesets.Osu.Mods
break; break;
} }
} else
{
switch(drawableObject)
{
case DrawableHitCircle circle:
if (!increaseVisibility)
{
// we don't want to see the approach circle
using (circle.BeginAbsoluteSequence(hitObject.StartTime - hitObject.TimePreempt))
circle.ApproachCircle.Hide();
}
break;
case DrawableSpinner spinner:
// hide elements we don't care about.
// todo: hide background
spinner.Body.OnSkinChanged += () => hideSpinnerApproachCircle(spinner);
hideSpinnerApproachCircle(spinner);
break;
default:
break;
}
}
} }
private (double fadeStartTime, double fadeDuration) getFadeOutParameters(DrawableOsuHitObject drawableObject) private (double fadeStartTime, double fadeDuration) getFadeOutParameters(DrawableOsuHitObject drawableObject)