sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 23:24:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Document why beatLength can be NaN

Browse Source
This commit is contained in:
Khang
2022-08-24 02:10:19 -04:00
parent ec9daec93b
commit c9f364d6a0
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Beatmaps/Formats/LegacyBeatmapDecoder.cs
View File

@ -373,6 +373,8 @@ namespace osu.Game.Beatmaps.Formats
string[] split = line.Split(','); string[] split = line.Split(',');
double time = getOffsetTime(Parsing.ParseDouble(split[0].Trim())); double time = getOffsetTime(Parsing.ParseDouble(split[0].Trim()));
// beatLength is allowed to be NaN to handle an edge case in which some beatmaps use NaN slider velocity to disable slider tick generation (see LegacyDifficultyControlPoint).
double beatLength = Parsing.ParseDouble(split[1].Trim(), allowNaN: true); double beatLength = Parsing.ParseDouble(split[1].Trim(), allowNaN: true);
// If beatLength is NaN, speedMultiplier should still be 1 because all comparisons against NaN are false. // If beatLength is NaN, speedMultiplier should still be 1 because all comparisons against NaN are false.