sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-31 02:17:34 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix assertions to work in both directions

Browse Source
This commit is contained in:
Dean Herbert 2022-01-30 02:54:51 +09:00
parent d3cb910cf8
commit d21464ea61
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapLeaderboard.cs
View File

@ -414,6 +414,7 @@ namespace osu.Game.Tests.Visual.SongSelect
{ {
public void SetRetrievalState(PlaceholderState state) public void SetRetrievalState(PlaceholderState state)
{ {
Scores = null;
PlaceholderState = state; PlaceholderState = state;
} }

9
osu.Game/Online/Leaderboards/Leaderboard.cs
View File

@ -243,11 +243,10 @@ namespace osu.Game.Online.Leaderboards
placeholderState = value; placeholderState = value;
Debug.Assert(placeholderState != PlaceholderState.Successful || scores?.Any() == true);
switch (placeholderState) switch (placeholderState)
{ {
case PlaceholderState.NetworkFailure: case PlaceholderState.NetworkFailure:
Debug.Assert(scores?.Any() != true);
replacePlaceholder(new ClickablePlaceholder(@"Couldn't fetch scores!", FontAwesome.Solid.Sync) replacePlaceholder(new ClickablePlaceholder(@"Couldn't fetch scores!", FontAwesome.Solid.Sync)
{ {
Action = RefetchScores Action = RefetchScores
@ -255,26 +254,32 @@ namespace osu.Game.Online.Leaderboards
break; break;
case PlaceholderState.NoneSelected: case PlaceholderState.NoneSelected:
Debug.Assert(scores?.Any() != true);
replacePlaceholder(new MessagePlaceholder(@"Please select a beatmap!")); replacePlaceholder(new MessagePlaceholder(@"Please select a beatmap!"));
break; break;
case PlaceholderState.Unavailable: case PlaceholderState.Unavailable:
Debug.Assert(scores?.Any() != true);
replacePlaceholder(new MessagePlaceholder(@"Leaderboards are not available for this beatmap!")); replacePlaceholder(new MessagePlaceholder(@"Leaderboards are not available for this beatmap!"));
break; break;
case PlaceholderState.NoScores: case PlaceholderState.NoScores:
Debug.Assert(scores?.Any() != true);
replacePlaceholder(new MessagePlaceholder(@"No records yet!")); replacePlaceholder(new MessagePlaceholder(@"No records yet!"));
break; break;
case PlaceholderState.NotLoggedIn: case PlaceholderState.NotLoggedIn:
Debug.Assert(scores?.Any() != true);
replacePlaceholder(new LoginPlaceholder(@"Please sign in to view online leaderboards!")); replacePlaceholder(new LoginPlaceholder(@"Please sign in to view online leaderboards!"));
break; break;
case PlaceholderState.NotSupporter: case PlaceholderState.NotSupporter:
Debug.Assert(scores?.Any() != true);
replacePlaceholder(new MessagePlaceholder(@"Please invest in an osu!supporter tag to view this leaderboard!")); replacePlaceholder(new MessagePlaceholder(@"Please invest in an osu!supporter tag to view this leaderboard!"));
break; break;
default: default:
Debug.Assert(scores?.Any() == true);
replacePlaceholder(null); replacePlaceholder(null);
break; break;
} }