sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-05 12:57:39 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite comments.

Browse Source
This commit is contained in:
smoogipooo 2017-05-26 16:10:04 +09:00
parent c2d3b6c05a
commit d3206396e7
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
View File

@ -127,15 +127,9 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
{ {
} }
/// <summary>
/// Handles key down events on the body of the hold note.
/// </summary>
/// <param name="state">The input state.</param>
/// <param name="args">The key down args.</param>
/// <returns>Whether the key press was handled.</returns>
protected override bool OnKeyDown(InputState state, KeyDownEventArgs args) protected override bool OnKeyDown(InputState state, KeyDownEventArgs args)
{ {
// Make sure the keypress happened within reasonable bounds of the hold note // Make sure the keypress happened within the body of the hold note
if (Time.Current < HitObject.StartTime || Time.Current > HitObject.EndTime) if (Time.Current < HitObject.StartTime || Time.Current > HitObject.EndTime)
return false; return false;
@ -145,17 +139,14 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
if (args.Repeat) if (args.Repeat)
return false; return false;
// The user has pressed during the body of the hold note, after the head note and its hit windows have passed
// and within the limited range of the above if-statement. This state will be managed by the head note if the
// user has pressed during the hit windows of the head note.
holding = true; holding = true;
return true; return true;
} }
/// <summary>
/// Handles key up events on the body of the hold note.
/// </summary>
/// <param name="state">The input state.</param>
/// <param name="args">The key down args.</param>
/// <returns>Whether the key press was handled.</returns>
protected override bool OnKeyUp(InputState state, KeyUpEventArgs args) protected override bool OnKeyUp(InputState state, KeyUpEventArgs args)
{ {
// Make sure that the user started holding the key during the hold note // Make sure that the user started holding the key during the hold note
@ -167,7 +158,7 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
holding = false; holding = false;
// If the key has been released too early, they should not receive full score for the release // If the key has been released too early, the user should not receive full score for the release
if (!tail.Judged) if (!tail.Judged)
hasBroken = true; hasBroken = true;
@ -196,13 +187,15 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
return false; return false;
// We only want to trigger a holding state from the head if the head has received a judgement // We only want to trigger a holding state from the head if the head has received a judgement
if (Judgement.Result == HitResult.None) if (!Judged)
return false; return false;
// If the head has been missed, make sure the user also can't receive a full score for the release // If the key has been released too early, the user should not receive full score for the release
if (Judgement.Result == HitResult.Miss) if (Judgement.Result == HitResult.Miss)
holdNote.hasBroken = true; holdNote.hasBroken = true;
// The head note also handles early hits before the body, but we want accurate early hits to count as the body being held
// The body doesn't handle these early early hits, so we have to explicitly set the holding state here
holdNote.holding = true; holdNote.holding = true;
return true; return true;