sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Comment about lifetime assumption

Browse Source
This commit is contained in:
ekrctb
2020-11-24 16:25:22 +09:00
parent ce57e8ddfb
commit d5f082e5fb
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs
View File

@ -147,11 +147,13 @@ namespace osu.Game.Rulesets.UI.Scrolling
/// <summary> /// <summary>
/// Invalidate the cache of the layout of this hit object. /// Invalidate the cache of the layout of this hit object.
/// A hit object should be invalidated after all its nested hit objects are invalidated.
/// </summary> /// </summary>
public void InvalidateDrawableHitObject(DrawableHitObject hitObject) public void InvalidateDrawableHitObject(DrawableHitObject hitObject)
{ {
// lifetime is computed before update // Lifetime is computed once early and
// layout (Width/Height if `IHasDuration`, and nested object positions) will be computed when the object becomes alive.
// An assumption is that a hit object layout update (setting `Height` or `Width`) won't affect its lifetime.
// This is satisfied in practice because otherwise the hit object won't be aligned to its `StartTime`.
hitObject.LifetimeStart = computeOriginAdjustedLifetimeStart(hitObject); hitObject.LifetimeStart = computeOriginAdjustedLifetimeStart(hitObject);
lifetimeComputedHitObjects.Add(hitObject); lifetimeComputedHitObjects.Add(hitObject);