From d66f07fccb10cae2aaf76020bab1c03313a11b56 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 27 May 2021 14:04:50 +0900
Subject: [PATCH] Move text and `isFullWidth` parameters to constructor

---
 osu.Game/Overlays/Wiki/WikiMainPage.cs       | 14 +++----------
 osu.Game/Overlays/Wiki/WikiPanelContainer.cs | 22 ++++++++++++--------
 2 files changed, 16 insertions(+), 20 deletions(-)

diff --git a/osu.Game/Overlays/Wiki/WikiMainPage.cs b/osu.Game/Overlays/Wiki/WikiMainPage.cs
index 8ff85c1404..bf4a76c3d8 100644
--- a/osu.Game/Overlays/Wiki/WikiMainPage.cs
+++ b/osu.Game/Overlays/Wiki/WikiMainPage.cs
@@ -77,10 +77,8 @@ namespace osu.Game.Overlays.Wiki
                 {
                     yield return new Drawable[]
                     {
-                        new WikiPanelContainer
+                        new WikiPanelContainer(panelsNode[i].InnerText, true)
                         {
-                            Text = panelsNode[i].InnerText,
-                            IsFullWidth = true,
                             Width = 2,
                         },
                         null,
@@ -91,14 +89,8 @@ namespace osu.Game.Overlays.Wiki
                 {
                     yield return new Drawable[]
                     {
-                        new WikiPanelContainer
-                        {
-                            Text = panelsNode[i].InnerText,
-                        },
-                        new WikiPanelContainer
-                        {
-                            Text = panelsNode[i + 1].InnerText,
-                        },
+                        new WikiPanelContainer(panelsNode[i].InnerText),
+                        new WikiPanelContainer(panelsNode[i + 1].InnerText),
                     };
                 }
             }
diff --git a/osu.Game/Overlays/Wiki/WikiPanelContainer.cs b/osu.Game/Overlays/Wiki/WikiPanelContainer.cs
index ad30306475..db213e4951 100644
--- a/osu.Game/Overlays/Wiki/WikiPanelContainer.cs
+++ b/osu.Game/Overlays/Wiki/WikiPanelContainer.cs
@@ -23,12 +23,15 @@ namespace osu.Game.Overlays.Wiki
     {
         private WikiPanelMarkdownContainer panelContainer;
 
-        public string Text;
+        private readonly string text;
 
-        public bool IsFullWidth;
+        private readonly bool isFullWidth;
 
-        public WikiPanelContainer()
+        public WikiPanelContainer(string text, bool isFullWidth = false)
         {
+            this.text = text;
+            this.isFullWidth = isFullWidth;
+
             RelativeSizeAxes = Axes.X;
             Padding = new MarginPadding(3);
         }
@@ -56,12 +59,11 @@ namespace osu.Game.Overlays.Wiki
                         RelativeSizeAxes = Axes.Both,
                     },
                 },
-                panelContainer = new WikiPanelMarkdownContainer
+                panelContainer = new WikiPanelMarkdownContainer(isFullWidth)
                 {
-                    Text = Text,
+                    Text = text,
                     RelativeSizeAxes = Axes.X,
                     AutoSizeAxes = Axes.Y,
-                    IsFullWidth = IsFullWidth,
                 }
             };
         }
@@ -74,10 +76,12 @@ namespace osu.Game.Overlays.Wiki
 
         private class WikiPanelMarkdownContainer : WikiMarkdownContainer
         {
-            public bool IsFullWidth;
+            private readonly bool isFullWidth;
 
-            public WikiPanelMarkdownContainer()
+            public WikiPanelMarkdownContainer(bool isFullWidth)
             {
+                this.isFullWidth = isFullWidth;
+
                 LineSpacing = 0;
                 DocumentPadding = new MarginPadding(30);
                 DocumentMargin = new MarginPadding(0);
@@ -92,7 +96,7 @@ namespace osu.Game.Overlays.Wiki
 
             protected override MarkdownHeading CreateHeading(HeadingBlock headingBlock) => new WikiPanelHeading(headingBlock)
             {
-                IsFullWidth = IsFullWidth,
+                IsFullWidth = isFullWidth,
             };
         }