From d81ef541bc8ff8f49119b4491a6842277c60983c Mon Sep 17 00:00:00 2001
From: Terochi <mates.cernicky@gmail.com>
Date: Mon, 21 Nov 2022 10:17:28 +0100
Subject: [PATCH] Variant 5: cannot change history, edit resets index

---
 .../UserInterface/TestSceneHistoryTextBox.cs  |  9 +-------
 .../Graphics/UserInterface/HistoryTextBox.cs  | 22 +------------------
 2 files changed, 2 insertions(+), 29 deletions(-)

diff --git a/osu.Game.Tests/Visual/UserInterface/TestSceneHistoryTextBox.cs b/osu.Game.Tests/Visual/UserInterface/TestSceneHistoryTextBox.cs
index 29f1e29b55..78b1bdb18c 100644
--- a/osu.Game.Tests/Visual/UserInterface/TestSceneHistoryTextBox.cs
+++ b/osu.Game.Tests/Visual/UserInterface/TestSceneHistoryTextBox.cs
@@ -3,7 +3,6 @@
 
 using NUnit.Framework;
 using osu.Framework.Graphics;
-using osu.Framework.Input;
 using osu.Game.Graphics;
 using osu.Game.Graphics.Sprites;
 using osu.Game.Graphics.UserInterface;
@@ -100,13 +99,7 @@ namespace osu.Game.Tests.Visual.UserInterface
             AddRepeatStep("Move Up", () => InputManager.Key(Key.Up), 2);
             AddAssert("Same as 1st message", () => box.Text == "Message 1");
 
-            AddStep("Remove text", () => box.Text = string.Empty);
-            AddStep("Move Up", () => InputManager.Key(Key.Up));
-            AddAssert("Same as previous message", () => box.Text == "Message 2");
-
-            AddStep("Move Up", () => InputManager.Key(Key.Up));
-            AddStep("Select text", () => InputManager.Keys(PlatformAction.SelectAll));
-            AddStep("Replace text", () => box.Text = "New text");
+            AddStep("Change text", () => box.Text = "New message");
             AddStep("Move Up", () => InputManager.Key(Key.Up));
             AddAssert("Same as previous message", () => box.Text == "Message 2");
         }
diff --git a/osu.Game/Graphics/UserInterface/HistoryTextBox.cs b/osu.Game/Graphics/UserInterface/HistoryTextBox.cs
index f2b975226c..0958e1832e 100644
--- a/osu.Game/Graphics/UserInterface/HistoryTextBox.cs
+++ b/osu.Game/Graphics/UserInterface/HistoryTextBox.cs
@@ -22,7 +22,6 @@ namespace osu.Game.Graphics.UserInterface
         private int selectedIndex;
 
         private string originalMessage = string.Empty;
-        private bool everythingSelected;
 
         /// <summary>
         /// Creates a new <see cref="HistoryTextBox"/>.
@@ -37,28 +36,13 @@ namespace osu.Game.Graphics.UserInterface
 
             Current.ValueChanged += text =>
             {
-                if (string.IsNullOrEmpty(text.NewValue) || everythingSelected)
+                if (selectedIndex != HistoryCount && text.NewValue != messageHistory[selectedIndex])
                 {
                     selectedIndex = HistoryCount;
-                    everythingSelected = false;
                 }
             };
         }
 
-        protected override void OnTextDeselected()
-        {
-            base.OnTextDeselected();
-
-            everythingSelected = false;
-        }
-
-        protected override void OnTextSelectionChanged(TextSelectionType selectionType)
-        {
-            base.OnTextSelectionChanged(selectionType);
-
-            everythingSelected = SelectedText == Text;
-        }
-
         protected override bool OnKeyDown(KeyDownEvent e)
         {
             switch (e.Key)
@@ -67,8 +51,6 @@ namespace osu.Game.Graphics.UserInterface
                     if (selectedIndex == 0)
                         return true;
 
-                    everythingSelected = false;
-
                     if (selectedIndex == HistoryCount)
                         originalMessage = Text;
 
@@ -80,8 +62,6 @@ namespace osu.Game.Graphics.UserInterface
                     if (selectedIndex == HistoryCount)
                         return true;
 
-                    everythingSelected = false;
-
                     if (selectedIndex == HistoryCount - 1)
                     {
                         selectedIndex = HistoryCount;