sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-18 20:17:23 +09:00
Code Issues Packages Projects Releases Wiki Activity

Cache ruleset + fix possible nullrefs

Browse Source
This commit is contained in:
smoogipoo 2020-05-28 20:07:51 +09:00
parent 7ac08620b8
commit d88bfa2080
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Online/API/RoomScore.cs
View File

@ -7,6 +7,7 @@ using System.Linq;
using Newtonsoft.Json; using Newtonsoft.Json;
using Newtonsoft.Json.Converters; using Newtonsoft.Json.Converters;
using osu.Game.Online.Multiplayer; using osu.Game.Online.Multiplayer;
using osu.Game.Rulesets.Mods;
using osu.Game.Rulesets.Scoring; using osu.Game.Rulesets.Scoring;
using osu.Game.Scoring; using osu.Game.Scoring;
using osu.Game.Users; using osu.Game.Users;
@ -48,6 +49,8 @@ namespace osu.Game.Online.API
public ScoreInfo CreateScoreInfo(PlaylistItem playlistItem) public ScoreInfo CreateScoreInfo(PlaylistItem playlistItem)
{ {
var rulesetInstance = playlistItem.Ruleset.Value.CreateInstance();
var scoreInfo = new ScoreInfo var scoreInfo = new ScoreInfo
{ {
OnlineScoreID = ID, OnlineScoreID = ID,
@ -62,7 +65,7 @@ namespace osu.Game.Online.API
Date = EndedAt, Date = EndedAt,
Hash = string.Empty, // todo: temporary? Hash = string.Empty, // todo: temporary?
Rank = Rank, Rank = Rank,
Mods = Mods.Select(m => m.ToMod(playlistItem.Ruleset.Value.CreateInstance())).ToArray() Mods = Mods?.Select(m => m.ToMod(rulesetInstance)).ToArray() ?? Array.Empty<Mod>()
}; };
return scoreInfo; return scoreInfo;