sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 16:13:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Don't unbind when not necessary

Browse Source
This commit is contained in:
ColdVolcano
2017-12-29 23:41:36 -06:00
parent 3845c7ac7d
commit df62ca14b7
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Screens/Play/Player.cs
View File

@ -311,10 +311,9 @@ namespace osu.Game.Screens.Play
if (!loadedSuccessfully) if (!loadedSuccessfully)
return; return;
dimLevel.ValueChanged += backgroundLevel_ValueChanged; dimLevel.ValueChanged += value => updateBackgroundElements();
blurLevel.ValueChanged += backgroundLevel_ValueChanged; blurLevel.ValueChanged += value => updateBackgroundElements();
showStoryboard.ValueChanged += value => updateBackgroundElements();
showStoryboard.ValueChanged += showStoryboard_ValueChanged;
updateBackgroundElements(); updateBackgroundElements();
Content.Alpha = 0; Content.Alpha = 0;
@ -370,12 +369,6 @@ namespace osu.Game.Screens.Play
return true; return true;
} }
private void backgroundLevel_ValueChanged(double newValue)
=> updateBackgroundElements();
private void showStoryboard_ValueChanged(bool newValue)
=> updateBackgroundElements();
private void updateBackgroundElements() private void updateBackgroundElements()
{ {
var opacity = 1 - (float)dimLevel; var opacity = 1 - (float)dimLevel;
@ -396,10 +389,6 @@ namespace osu.Game.Screens.Play
private void fadeOut() private void fadeOut()
{ {
dimLevel.ValueChanged -= backgroundLevel_ValueChanged;
blurLevel.ValueChanged -= backgroundLevel_ValueChanged;
showStoryboard.ValueChanged -= showStoryboard_ValueChanged;
const float fade_out_duration = 250; const float fade_out_duration = 250;
RulesetContainer?.FadeOut(fade_out_duration); RulesetContainer?.FadeOut(fade_out_duration);