Remove import popup dialog from song select

This has been replaced in spirit by the first run overlay.

osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs

@@ -609,8 +609,6 @@ namespace osu.Game.Tests.Visual.Navigation
             public ModSelectOverlay ModSelectOverlay => ModSelect;
 
             public BeatmapOptionsOverlay BeatmapOptionsOverlay => BeatmapOptions;
-
-            protected override bool DisplayStableImportPrompt => false;
         }
     }
 }

osu.Game/Screens/Select/ImportFromStablePopup.cs

@@ -1,33 +0,0 @@
-// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
-// See the LICENCE file in the repository root for full licence text.
-
-using System;
-using osu.Framework.Graphics.Sprites;
-using osu.Game.Overlays.Dialog;
-
-namespace osu.Game.Screens.Select
-{
-    public class ImportFromStablePopup : PopupDialog
-    {
-        public ImportFromStablePopup(Action importFromStable)
-        {
-            HeaderText = @"You have no beatmaps!";
-            BodyText = "Would you like to import your beatmaps, skins, collections and scores from an existing osu!stable installation?\nThis will create a second copy of all files on disk.";
-
-            Icon = FontAwesome.Solid.Plane;
-
-            Buttons = new PopupDialogButton[]
-            {
-                new PopupDialogOkButton
-                {
-                    Text = @"Yes please!",
-                    Action = importFromStable
-                },
-                new PopupDialogCancelButton
-                {
-                    Text = @"No, I'd like to start from scratch",
-                },
-            };
-        }
-    }
-}

osu.Game/Screens/Select/SongSelect.cs

@@ -28,7 +28,6 @@ using osuTK.Input;
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Threading.Tasks;
 using osu.Framework.Audio.Track;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Input.Bindings;
@@ -37,7 +36,6 @@ using osu.Game.Graphics.UserInterface;
 using System.Diagnostics;
 using JetBrains.Annotations;
 using osu.Game.Screens.Play;
-using osu.Game.Database;
 using osu.Game.Skinning;
 
 namespace osu.Game.Screens.Select
@@ -59,8 +57,6 @@ namespace osu.Game.Screens.Select
 
         protected virtual bool ShowFooter => true;
 
-        protected virtual bool DisplayStableImportPrompt => legacyImportManager?.SupportsImportFromStable == true;
-
         public override bool? AllowTrackAdjustments => true;
 
         /// <summary>
@@ -94,14 +90,13 @@ namespace osu.Game.Screens.Select
         protected Container LeftArea { get; private set; }
 
         private BeatmapInfoWedge beatmapInfoWedge;
-        private IDialogOverlay dialogOverlay;
+
+        [Resolved]
+        private IDialogOverlay dialogOverlay { get; set; }
 
         [Resolved]
         private BeatmapManager beatmaps { get; set; }
 
-        [Resolved(CanBeNull = true)]
-        private LegacyImportManager legacyImportManager { get; set; }
-
         protected ModSelectOverlay ModSelect { get; private set; }
 
         protected Sample SampleConfirm { get; private set; }
@@ -127,7 +122,7 @@ namespace osu.Game.Screens.Select
         internal IOverlayManager OverlayManager { get; private set; }
 
         [BackgroundDependencyLoader(true)]
-        private void load(AudioManager audio, IDialogOverlay dialog, OsuColour colours, ManageCollectionsDialog manageCollectionsDialog, DifficultyRecommender recommender)
+        private void load(AudioManager audio, OsuColour colours, ManageCollectionsDialog manageCollectionsDialog, DifficultyRecommender recommender)
         {
             // initial value transfer is required for FilterControl (it uses our re-cached bindables in its async load for the initial filter).
             transferRulesetValue();
@@ -289,26 +284,9 @@ namespace osu.Game.Screens.Select
                 BeatmapOptions.AddButton(@"Clear", @"local scores", FontAwesome.Solid.Eraser, colours.Purple, () => clearScores(Beatmap.Value.BeatmapInfo));
             }
 
-            dialogOverlay = dialog;
-
             sampleChangeDifficulty = audio.Samples.Get(@"SongSelect/select-difficulty");
             sampleChangeBeatmap = audio.Samples.Get(@"SongSelect/select-expand");
             SampleConfirm = audio.Samples.Get(@"SongSelect/confirm-selection");
-
-            if (dialogOverlay != null)
-            {
-                Schedule(() =>
-                {
-                    // if we have no beatmaps, let's prompt the user to import from over a stable install if he has one.
-                    if (beatmaps.QueryBeatmapSet(s => !s.Protected && !s.DeletePending) == null && DisplayStableImportPrompt)
-                    {
-                        dialogOverlay.Push(new ImportFromStablePopup(() =>
-                        {
-                            Task.Run(() => legacyImportManager.ImportFromStableAsync(StableContent.All));
-                        }));
-                    }
-                });
-            }
         }
 
         protected override void LoadComplete()