sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 09:03:50 +09:00
Code Issues Packages Projects Releases Wiki Activity

Replace lifetime workaround with explicit set

Browse Source
This commit is contained in:
Bartłomiej Dach
2021-06-11 12:09:40 +02:00
parent 7bb27bfd0e
commit e194f8b34a
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Rulesets.Taiko/Mods/TaikoModHidden.cs
View File

@ -7,7 +7,9 @@ using osu.Game.Beatmaps;
using osu.Game.Beatmaps.ControlPoints; using osu.Game.Beatmaps.ControlPoints;
using osu.Game.Configuration; using osu.Game.Configuration;
using osu.Game.Rulesets.Mods; using osu.Game.Rulesets.Mods;
using osu.Game.Rulesets.Objects;
using osu.Game.Rulesets.Objects.Drawables; using osu.Game.Rulesets.Objects.Drawables;
using osu.Game.Rulesets.Scoring;
using osu.Game.Rulesets.Taiko.Objects.Drawables; using osu.Game.Rulesets.Taiko.Objects.Drawables;
namespace osu.Game.Rulesets.Taiko.Mods namespace osu.Game.Rulesets.Taiko.Mods
@ -70,9 +72,13 @@ namespace osu.Game.Rulesets.Taiko.Mods
using (hitObject.BeginAbsoluteSequence(start)) using (hitObject.BeginAbsoluteSequence(start))
{ {
// With 0 opacity the object is dying, and if I set a lifetime other issues appear... hitObject.FadeOut(duration);
// Ideally these need to be fixed, but I lack the knowledge to do it, and this is good enough anyway.
hitObject.FadeTo(0.0005f, duration); // DrawableHitObject sets LifetimeEnd to LatestTransformEndTime if it isn't manually changed.
// in order for the object to not be killed before its actual end time (as the latest transform ends earlier), set lifetime end explicitly.
hitObject.LifetimeEnd = state == ArmedState.Idle
? hitObject.HitObject.GetEndTime() + hitObject.HitObject.HitWindows.WindowFor(HitResult.Miss)
: hitObject.HitStateUpdateTime;
} }
} }