sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-08 12:58:01 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15855 from peppy/live-post-construction-attach

Browse Source 
Fix `RealmLive` not working if data is attached to realm post-`ToLive` call
This commit is contained in:
Dan Balasescu 2021-11-29 18:14:08 +09:00 committed by GitHub
commit e2cb420c06
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
osu.Game.Tests/Database/RealmLiveTests.cs
View File

@ -29,6 +29,22 @@ namespace osu.Game.Tests.Database
}); });
} }
[Test]
public void TestAccessAfterAttach()
{
RunTestWithRealm((realmFactory, _) =>
{
var beatmap = new RealmBeatmap(CreateRuleset(), new RealmBeatmapDifficulty(), new RealmBeatmapMetadata());
var liveBeatmap = beatmap.ToLive();
using (var context = realmFactory.CreateContext())
context.Write(r => r.Add(beatmap));
Assert.IsFalse(liveBeatmap.PerformRead(l => l.Hidden));
});
}
[Test] [Test]
public void TestAccessNonManaged() public void TestAccessNonManaged()
{ {

4
osu.Game/Database/RealmLive.cs
View File

@ -17,7 +17,7 @@ namespace osu.Game.Database
{ {
public Guid ID { get; } public Guid ID { get; }
public bool IsManaged { get; } public bool IsManaged => data.IsManaged;
private readonly SynchronizationContext? fetchedContext; private readonly SynchronizationContext? fetchedContext;
private readonly int fetchedThreadId; private readonly int fetchedThreadId;
@ -37,8 +37,6 @@ namespace osu.Game.Database
if (data.IsManaged) if (data.IsManaged)
{ {
IsManaged = true;
fetchedContext = SynchronizationContext.Current; fetchedContext = SynchronizationContext.Current;
fetchedThreadId = Thread.CurrentThread.ManagedThreadId; fetchedThreadId = Thread.CurrentThread.ManagedThreadId;
} }