sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-07 00:23:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add some explanatory comments to conditions

Browse Source
This commit is contained in:
Dan Balasescu
2022-08-25 17:14:35 +09:00
parent eb57ea76ab
commit e2e10a8f26
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Rulesets/Scoring/HitResult.cs
View File

@ -175,6 +175,7 @@ namespace osu.Game.Rulesets.Scoring
/// </summary> /// </summary>
public static bool AffectsAccuracy(this HitResult result) public static bool AffectsAccuracy(this HitResult result)
{ {
// LegacyComboIncrease is a special type which is neither a basic, tick, bonus, or accuracy-affecting result.
if (result == HitResult.LegacyComboIncrease) if (result == HitResult.LegacyComboIncrease)
return false; return false;
@ -186,6 +187,7 @@ namespace osu.Game.Rulesets.Scoring
/// </summary> /// </summary>
public static bool IsBasic(this HitResult result) public static bool IsBasic(this HitResult result)
{ {
// LegacyComboIncrease is a special type which is neither a basic, tick, bonus, or accuracy-affecting result.
if (result == HitResult.LegacyComboIncrease) if (result == HitResult.LegacyComboIncrease)
return false; return false;
@ -250,6 +252,7 @@ namespace osu.Game.Rulesets.Scoring
/// </summary> /// </summary>
public static bool IsScorable(this HitResult result) public static bool IsScorable(this HitResult result)
{ {
// LegacyComboIncrease is not actually scorable (in terms of usable by rulesets for that purpose), but needs to be defined as such to be correctly included in statistics output.
if (result == HitResult.LegacyComboIncrease) if (result == HitResult.LegacyComboIncrease)
return true; return true;