sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 08:49:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add more resilient logic for whether to avoid playing SkinnableSound on no volume

Browse Source
This commit is contained in:
Dean Herbert
2020-08-06 19:16:26 +09:00
parent c68fb92d00
commit e3105fd4c8
3 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Skinning/SkinnableSound.cs
View File

@ -28,6 +28,16 @@ namespace osu.Game.Skinning
public override bool RemoveWhenNotAlive => false;
public override bool RemoveCompletedTransforms => false;
/// <summary>
/// Whether to play the underlying sample when aggregate volume is zero.
/// Note that this is checked at the point of calling <see cref="Play"/>; changing the volume post-play will not begin playback.
/// Defaults to false unless <see cref="Looping"/>.
/// </summary>
/// <remarks>
/// Can serve as an optimisation if it is known ahead-of-time that this behaviour will not negatively affect behaviour.
/// </remarks>
protected bool SkipPlayWhenZeroVolume => !Looping;
private readonly AudioContainer<DrawableSample> samplesContainer;
public SkinnableSound(ISampleInfo hitSamples)
@ -87,7 +97,7 @@ namespace osu.Game.Skinning
{
samplesContainer.ForEach(c =>
{
if (c.AggregateVolume.Value > 0)
if (!SkipPlayWhenZeroVolume || c.AggregateVolume.Value > 0)
c.Play();
});
}