sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-11 08:37:34 +09:00
Code Issues Packages Projects Releases Wiki Activity

Use BindTarget instead of caching for ControlItem unread flow

Browse Source
This commit is contained in:
Jai Sharma 2022-03-15 22:37:15 +00:00
parent 49b74d7867
commit e38d9eafa0
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Overlays/Chat/ChannelControl/ControlItem.cs
View File

@ -22,7 +22,6 @@ namespace osu.Game.Overlays.Chat.ChannelControl
public readonly BindableInt Mentions = new BindableInt(); public readonly BindableInt Mentions = new BindableInt();
[Cached]
public readonly BindableBool Unread = new BindableBool(); public readonly BindableBool Unread = new BindableBool();
private readonly Channel channel; private readonly Channel channel;
@ -85,6 +84,7 @@ namespace osu.Game.Overlays.Chat.ChannelControl
{ {
Anchor = Anchor.CentreLeft, Anchor = Anchor.CentreLeft,
Origin = Anchor.CentreLeft, Origin = Anchor.CentreLeft,
Unread = { BindTarget = Unread },
}, },
new ControlItemMention new ControlItemMention
{ {

7
osu.Game/Overlays/Chat/ChannelControl/ControlItemText.cs
View File

@ -15,13 +15,12 @@ namespace osu.Game.Overlays.Chat.ChannelControl
{ {
public class ControlItemText : Container public class ControlItemText : Container
{ {
public readonly BindableBool Unread = new BindableBool();
private readonly Channel channel; private readonly Channel channel;
private OsuSpriteText? text; private OsuSpriteText? text;
[Resolved]
private BindableBool unread { get; set; } = null!;
[Resolved] [Resolved]
private OverlayColourProvider colourProvider { get; set; } = null!; private OverlayColourProvider colourProvider { get; set; } = null!;
@ -51,7 +50,7 @@ namespace osu.Game.Overlays.Chat.ChannelControl
{ {
base.LoadComplete(); base.LoadComplete();
unread.BindValueChanged(change => Unread.BindValueChanged(change =>
{ {
text!.Colour = change.NewValue ? colourProvider.Content1 : colourProvider.Light3; text!.Colour = change.NewValue ? colourProvider.Content1 : colourProvider.Light3;
}, true); }, true);