Remake OsuTabControl.AccentColour

osu.Game/Graphics/UserInterface/OsuTabControl.cs

@@ -21,19 +21,16 @@ namespace osu.Game.Graphics.UserInterface
 {
     public class OsuTabControl<T> : TabControl<T>
     {
-        protected readonly Bindable<Color4> AccentColourBindable = new Bindable<Color4>();
+        private Color4 accentColour;
 
         public Color4 AccentColour
         {
-            get => AccentColourBindable.Value;
+            get => accentColour;
             set
             {
-                AccentColourBindable.Value = value;
+                accentColour = value;
 
-                if (Dropdown is IHasAccentColour dropdown)
+                OnAccentColourChanged(value);
-                    dropdown.AccentColour = value;
-                foreach (var i in TabContainer.Children.OfType<IHasAccentColour>())
-                    i.AccentColour = value;
             }
         }
 
@@ -93,6 +90,14 @@ namespace osu.Game.Graphics.UserInterface
                 strip.Width = Interpolation.ValueAt(Math.Clamp(Clock.ElapsedFrameTime, 0, 1000), strip.Width, StripWidth, 0, 500, Easing.OutQuint);
         }
 
+        protected virtual void OnAccentColourChanged(Color4 colour)
+        {
+            if (Dropdown is IHasAccentColour dropdown)
+                dropdown.AccentColour = colour;
+            foreach (var i in TabContainer.Children.OfType<IHasAccentColour>())
+                i.AccentColour = colour;
+        }
+
         public class OsuTabItem : TabItem<T>, IHasAccentColour
         {
             protected readonly SpriteText Text;

osu.Game/Overlays/OverlayTabControl.cs

@@ -36,10 +36,10 @@ namespace osu.Game.Overlays
             });
         }
 
-        protected override void LoadComplete()
+        protected override void OnAccentColourChanged(Color4 colour)
         {
-            base.LoadComplete();
+            base.OnAccentColourChanged(colour);
-            AccentColourBindable.BindValueChanged(colour => bar.Colour = colour.NewValue, true);
+            bar.Colour = colour;
         }
 
         protected override Dropdown<T> CreateDropdown() => null;