From e7c85d38a8a3e5b6c428b92a6a6bf31dd6b623f6 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Sat, 23 Dec 2017 19:17:05 +0900 Subject: [PATCH] Move list initialisation to pattern generation code --- .../Patterns/Legacy/EndTimeObjectPatternGenerator.cs | 8 ++++---- osu.Game.Rulesets.Mania/Objects/HoldNote.cs | 5 +---- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/osu.Game.Rulesets.Mania/Beatmaps/Patterns/Legacy/EndTimeObjectPatternGenerator.cs b/osu.Game.Rulesets.Mania/Beatmaps/Patterns/Legacy/EndTimeObjectPatternGenerator.cs index c353496410..3e9fc1ae27 100644 --- a/osu.Game.Rulesets.Mania/Beatmaps/Patterns/Legacy/EndTimeObjectPatternGenerator.cs +++ b/osu.Game.Rulesets.Mania/Beatmaps/Patterns/Legacy/EndTimeObjectPatternGenerator.cs @@ -76,10 +76,10 @@ namespace osu.Game.Rulesets.Mania.Beatmaps.Patterns.Legacy Duration = endTime - HitObject.StartTime }; - hold.Head.Samples.Add(new SampleInfo - { - Name = SampleInfo.HIT_NORMAL - }); + if (hold.Head.Samples == null) + hold.Head.Samples = new SampleInfoList(); + + hold.Head.Samples.Add(new SampleInfo { Name = SampleInfo.HIT_NORMAL }); hold.Tail.Samples = HitObject.Samples; diff --git a/osu.Game.Rulesets.Mania/Objects/HoldNote.cs b/osu.Game.Rulesets.Mania/Objects/HoldNote.cs index 103a33ce04..f72bed3142 100644 --- a/osu.Game.Rulesets.Mania/Objects/HoldNote.cs +++ b/osu.Game.Rulesets.Mania/Objects/HoldNote.cs @@ -50,10 +50,7 @@ namespace osu.Game.Rulesets.Mania.Objects /// /// The head note of the hold. /// - public readonly Note Head = new Note - { - Samples = new Audio.SampleInfoList() - }; + public readonly Note Head = new Note(); /// /// The tail note of the hold.