sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 08:49:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Mark delegate value unused and add comment to avoid future regression

Browse Source
This commit is contained in:
Dean Herbert
2023-05-02 13:29:30 +09:00
parent 7cedbca9be
commit e808e7316b
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Overlays/Mods/ModSelectOverlay.cs
View File

@ -242,7 +242,7 @@ namespace osu.Game.Overlays.Mods
if (AllowCustomisation) if (AllowCustomisation)
((IBindable<IReadOnlyList<Mod>>)modSettingsArea.SelectedMods).BindTo(SelectedMods); ((IBindable<IReadOnlyList<Mod>>)modSettingsArea.SelectedMods).BindTo(SelectedMods);
SelectedMods.BindValueChanged(val => SelectedMods.BindValueChanged(_ =>
{ {
updateMultiplier(); updateMultiplier();
updateFromExternalSelection(); updateFromExternalSelection();
@ -252,6 +252,10 @@ namespace osu.Game.Overlays.Mods
if (AllowCustomisation) if (AllowCustomisation)
{ {
// Importantly, use SelectedMods.Value here (and not the ValueChanged NewValue) as the latter can
// potentially be stale, due to complexities in the way change trackers work.
//
// See https://github.com/ppy/osu/pull/23284#issuecomment-1529056988
modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value); modSettingChangeTracker = new ModSettingChangeTracker(SelectedMods.Value);
modSettingChangeTracker.SettingChanged += _ => updateMultiplier(); modSettingChangeTracker.SettingChanged += _ => updateMultiplier();
} }