From e9b51371476ca3adb6a00e9aca26ff5b600dae51 Mon Sep 17 00:00:00 2001
From: voidedWarranties <wz68.scratch@gmail.com>
Date: Tue, 11 Feb 2020 21:52:22 -0800
Subject: [PATCH] Remove >-1 limitation by using a separate constructor

---
 osu.Game/Configuration/SettingSourceAttribute.cs | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/osu.Game/Configuration/SettingSourceAttribute.cs b/osu.Game/Configuration/SettingSourceAttribute.cs
index 4dcd2c6122..013621d7b7 100644
--- a/osu.Game/Configuration/SettingSourceAttribute.cs
+++ b/osu.Game/Configuration/SettingSourceAttribute.cs
@@ -29,12 +29,17 @@ namespace osu.Game.Configuration
 
         public string Description { get; }
 
-        public int OrderPosition { get; }
+        public int? OrderPosition { get; }
 
-        public SettingSourceAttribute(string label, string description = null, int orderPosition = -1)
+        public SettingSourceAttribute(string label, string description = null)
         {
             Label = label ?? string.Empty;
             Description = description ?? string.Empty;
+        }
+
+        public SettingSourceAttribute(string label, string description, int orderPosition)
+            : this(label, description)
+        {
             OrderPosition = orderPosition;
         }
     }
@@ -129,7 +134,7 @@ namespace osu.Game.Configuration
         {
             var original = obj.GetSettingsSourceProperties();
 
-            var orderedRelative = original.Where(attr => attr.Item1.OrderPosition > -1).OrderBy(attr => attr.Item1.OrderPosition);
+            var orderedRelative = original.Where(attr => attr.Item1.OrderPosition != null).OrderBy(attr => attr.Item1.OrderPosition);
             var unordered = original.Except(orderedRelative);
 
             return orderedRelative.Concat(unordered);