sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 00:40:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix unsafe sample playback in GameplaySampleTriggerSource

Browse Source 
Resolves https://github.com/ppy/osu/issues/18727.

Added delay from `Schedule` should be minimal as it is always called
from the `Update` thread (input propagation) anyway.
This commit is contained in:
Dean Herbert
2022-06-16 16:04:52 +09:00
parent e778c90930
commit ec53d87c30
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/UI/GameplaySampleTriggerSource.cs
View File

@ -56,12 +56,12 @@ namespace osu.Game.Rulesets.UI
PlaySamples(samples); PlaySamples(samples);
} }
protected void PlaySamples(ISampleInfo[] samples) protected void PlaySamples(ISampleInfo[] samples) => Schedule(() =>
{ {
var hitSound = getNextSample(); var hitSound = getNextSample();
hitSound.Samples = samples; hitSound.Samples = samples;
hitSound.Play(); hitSound.Play();
} });
protected HitObject GetMostValidObject() protected HitObject GetMostValidObject()
{ {