Add protection against migrating to a nested folder

2025-07-01 00:09:55 +09:00 · 2020-05-14 22:42:42 +09:00
parent 9d557bf806
commit ef8375b442
2 changed files with 30 additions and 0 deletions
--- a/osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs
+++ b/osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs
@ -220,6 +220,30 @@ namespace osu.Game.Tests.NonVisual
            }
        }

+        [Test]
+        public void TestMigrationToNestedTargetFails()
+        {
+            using (HeadlessGameHost host = new CleanRunHeadlessGameHost(nameof(TestMigrationToSameTargetFails)))
+            {
+                try
+                {
+                    var osu = loadOsu(host);
+
+                    Assert.DoesNotThrow(() => osu.Migrate(customPath));
+
+                    string subFolder = Path.Combine(customPath, "sub");
+
+                    Directory.CreateDirectory(subFolder);
+
+                    Assert.Throws<ArgumentException>(() => osu.Migrate(subFolder));
+                }
+                finally
+                {
+                    host.Exit();
+                }
+            }
+        }
+
        private OsuGameBase loadOsu(GameHost host)
        {
            var osu = new OsuGameBase();