From f1da213beaaaba85b82c785def1c43f6cb1f62ec Mon Sep 17 00:00:00 2001
From: Cootz <artem2004799@gmail.com>
Date: Thu, 16 Feb 2023 16:26:57 +0300
Subject: [PATCH] Add tests

---
 osu.Game.Tests/Database/LegacyExporterTest.cs | 85 +++++++++++++++++++
 osu.Game/Database/LegacyExporter.cs           |  6 +-
 2 files changed, 88 insertions(+), 3 deletions(-)
 create mode 100644 osu.Game.Tests/Database/LegacyExporterTest.cs

diff --git a/osu.Game.Tests/Database/LegacyExporterTest.cs b/osu.Game.Tests/Database/LegacyExporterTest.cs
new file mode 100644
index 0000000000..5f07e6c917
--- /dev/null
+++ b/osu.Game.Tests/Database/LegacyExporterTest.cs
@@ -0,0 +1,85 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.IO;
+using System.Text;
+using NUnit.Framework;
+using osu.Framework.Platform;
+using osu.Framework.Testing;
+using osu.Game.Database;
+
+namespace osu.Game.Tests.Database
+{
+    public class LegacyExporterTest
+    {
+        private TestLegacyExporter? legacyExporter;
+        private TemporaryNativeStorage? storage;
+
+        [SetUp]
+        public void SetupLegacyExporter()
+        {
+            storage = new TemporaryNativeStorage("export-storage");
+            legacyExporter = new TestLegacyExporter(storage);
+        }
+
+        [Test]
+        public void ExportFileWithNormalName()
+        {
+            var exportStorage = storage?.GetStorageForDirectory(@"exports");
+
+            string filename = "normal file name";
+            var item = new TestPathInfo(filename);
+
+            Assert.That(item.FileName.Length < TestLegacyExporter.GetMaxPath(), Is.True);
+            Assert.DoesNotThrow(() => legacyExporter?.Export(item));
+            Assert.That(exportStorage?.Exists($"{filename}{legacyExporter?.GetExtension()}"), Is.True);
+        }
+
+        [Test]
+        public void ExportFileWithSuperLongName()
+        {
+            var exportStorage = storage?.GetStorageForDirectory(@"exports");
+
+            string fullname = "some file with super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name super long name";
+
+            int capacity = TestLegacyExporter.GetMaxPath() - (legacyExporter?.GetExtension().Length ?? 0);
+            string expectedName = fullname.Remove(capacity);
+
+            var item = new TestPathInfo(fullname);
+
+            Assert.That(item.FileName.Length > TestLegacyExporter.GetMaxPath(), Is.True);
+            Assert.DoesNotThrow(() => legacyExporter?.Export(item));
+            Assert.That(exportStorage?.Exists($"{expectedName}{legacyExporter?.GetExtension()}"), Is.True);
+        }
+
+        [TearDown]
+        public void CleanupAfterTest()
+        {
+            storage?.Dispose();
+        }
+
+        private class TestPathInfo : IHasNamedFiles
+        {
+            public string FileName { get; set; } = string.Empty;
+
+            public TestPathInfo(string fileName) => FileName = fileName;
+
+            public IEnumerable<INamedFileUsage> Files { get; set; } = new List<INamedFileUsage>();
+
+            public override string ToString() => FileName;
+        }
+
+        private class TestLegacyExporter : LegacyExporter<IHasNamedFiles>
+        {
+            public TestLegacyExporter(Storage storage) : base(storage) { }
+
+            public static int GetMaxPath() => MAX_PATH;
+
+            public string GetExtension() => FileExtension;
+
+            protected override string FileExtension => ".ots";
+        }
+    }
+}
diff --git a/osu.Game/Database/LegacyExporter.cs b/osu.Game/Database/LegacyExporter.cs
index 483c3cbd5c..9041f58368 100644
--- a/osu.Game/Database/LegacyExporter.cs
+++ b/osu.Game/Database/LegacyExporter.cs
@@ -26,7 +26,7 @@ namespace osu.Game.Database
         /// <remarks>
         /// This constant is smaller 256 because <see cref="Storage.CreateFileSafely(string)"/> adds additional "_<see cref="Guid"/>" to the end of the path
         /// </remarks>
-        private const int max_path = 255 - (32 + 4 + 2); //max path - (Guid + Guid "D" format chars + Storage.CreateFileSafely chars)
+        protected const int MAX_PATH = 255 - (32 + 4 + 2); //max path - (Guid + Guid "D" format chars + Storage.CreateFileSafely chars)
 
         /// <summary>
         /// The file extension for exports (including the leading '.').
@@ -60,11 +60,11 @@ namespace osu.Game.Database
 
             string filename = NamingUtils.GetNextBestFilename(existingExports, $"{itemFilename}{FileExtension}");
 
-            if (filename.Length > max_path)
+            if (filename.Length > MAX_PATH)
             {
                 string filenameWithoutExtension = Path.GetFileNameWithoutExtension(filename);
 
-                filenameWithoutExtension = filenameWithoutExtension.Remove(max_path - FileExtension.Length); //Truncating the name to fit the path limit
+                filenameWithoutExtension = filenameWithoutExtension.Remove(MAX_PATH - FileExtension.Length); //Truncating the name to fit the path limit
                 filename = $"{filenameWithoutExtension}{FileExtension}";
             }