From f1decb667e431e1adc007d830e3cddd7b836dd75 Mon Sep 17 00:00:00 2001
From: Joseph Madamba <madamba.joehu@outlook.com>
Date: Wed, 8 Feb 2023 17:51:28 -0800
Subject: [PATCH] Address todos relating to init-only usages

---
 .../Profile/Header/Components/RankGraph.cs         | 10 ++++++----
 .../Sections/Historical/UserHistoryGraph.cs        | 10 ++++++----
 osu.Game/Overlays/Profile/UserGraph.cs             | 14 +++-----------
 .../Tests/Visual/DependencyProvidingContainer.cs   |  3 +--
 4 files changed, 16 insertions(+), 21 deletions(-)

diff --git a/osu.Game/Overlays/Profile/Header/Components/RankGraph.cs b/osu.Game/Overlays/Profile/Header/Components/RankGraph.cs
index fe1069eea1..4f3f1ac2c3 100644
--- a/osu.Game/Overlays/Profile/Header/Components/RankGraph.cs
+++ b/osu.Game/Overlays/Profile/Header/Components/RankGraph.cs
@@ -66,10 +66,12 @@ namespace osu.Game.Overlays.Profile.Header.Components
         {
             int days = ranked_days - index + 1;
 
-            return new UserGraphTooltipContent(
-                UsersStrings.ShowRankGlobalSimple,
-                rank.ToLocalisableString("\\##,##0"),
-                days == 0 ? "now" : $"{"day".ToQuantity(days)} ago");
+            return new UserGraphTooltipContent
+            {
+                Name = UsersStrings.ShowRankGlobalSimple,
+                Count = rank.ToLocalisableString("\\##,##0"),
+                Time = days == 0 ? "now" : $"{"day".ToQuantity(days)} ago",
+            };
         }
     }
 }
diff --git a/osu.Game/Overlays/Profile/Sections/Historical/UserHistoryGraph.cs b/osu.Game/Overlays/Profile/Sections/Historical/UserHistoryGraph.cs
index 310607e757..0259231001 100644
--- a/osu.Game/Overlays/Profile/Sections/Historical/UserHistoryGraph.cs
+++ b/osu.Game/Overlays/Profile/Sections/Historical/UserHistoryGraph.cs
@@ -27,9 +27,11 @@ namespace osu.Game.Overlays.Profile.Sections.Historical
         protected override float GetDataPointHeight(long playCount) => playCount;
 
         protected override UserGraphTooltipContent GetTooltipContent(DateTime date, long playCount) =>
-            new UserGraphTooltipContent(
-                tooltipCounterName,
-                playCount.ToLocalisableString("N0"),
-                date.ToLocalisableString("MMMM yyyy"));
+            new UserGraphTooltipContent
+            {
+                Name = tooltipCounterName,
+                Count = playCount.ToLocalisableString("N0"),
+                Time = date.ToLocalisableString("MMMM yyyy")
+            };
     }
 }
diff --git a/osu.Game/Overlays/Profile/UserGraph.cs b/osu.Game/Overlays/Profile/UserGraph.cs
index 63cdbea5a4..0a5e6ca710 100644
--- a/osu.Game/Overlays/Profile/UserGraph.cs
+++ b/osu.Game/Overlays/Profile/UserGraph.cs
@@ -298,16 +298,8 @@ namespace osu.Game.Overlays.Profile
 
     public class UserGraphTooltipContent
     {
-        // todo: could use init-only properties on C# 9 which read better than a constructor.
-        public LocalisableString Name { get; }
-        public LocalisableString Count { get; }
-        public LocalisableString Time { get; }
-
-        public UserGraphTooltipContent(LocalisableString name, LocalisableString count, LocalisableString time)
-        {
-            Name = name;
-            Count = count;
-            Time = time;
-        }
+        public LocalisableString Name { get; init; }
+        public LocalisableString Count { get; init; }
+        public LocalisableString Time { get; init; }
     }
 }
diff --git a/osu.Game/Tests/Visual/DependencyProvidingContainer.cs b/osu.Game/Tests/Visual/DependencyProvidingContainer.cs
index ae0225d8df..acfff4cefe 100644
--- a/osu.Game/Tests/Visual/DependencyProvidingContainer.cs
+++ b/osu.Game/Tests/Visual/DependencyProvidingContainer.cs
@@ -20,8 +20,7 @@ namespace osu.Game.Tests.Visual
         /// <summary>
         /// The dependencies provided to the children.
         /// </summary>
-        // TODO: should be an init-only property when C# 9
-        public (Type, object)[] CachedDependencies { get; set; } = Array.Empty<(Type, object)>();
+        public (Type, object)[] CachedDependencies { get; init; } = Array.Empty<(Type, object)>();
 
         protected override IReadOnlyDependencyContainer CreateChildDependencies(IReadOnlyDependencyContainer parent)
         {