Move some suggestions to warnings, resolve issues

This commit is contained in:
smoogipoo
2020-06-03 16:48:44 +09:00
parent 5f1d44a2be
commit f3b5149648
22 changed files with 34 additions and 58 deletions

View File

@ -164,7 +164,7 @@ namespace osu.Game
dependencies.Cache(SkinManager = new SkinManager(Storage, contextFactory, Host, Audio, new NamespacedResourceStore<byte[]>(Resources, "Skins/Legacy")));
dependencies.CacheAs<ISkinSource>(SkinManager);
if (API == null) API = new APIAccess(LocalConfig);
API ??= new APIAccess(LocalConfig);
dependencies.CacheAs(API);
@ -311,11 +311,10 @@ namespace osu.Game
{
base.SetHost(host);
if (Storage == null) // may be non-null for certain tests
Storage = new OsuStorage(host);
// may be non-null for certain tests
Storage ??= new OsuStorage(host);
if (LocalConfig == null)
LocalConfig = new OsuConfigManager(Storage);
LocalConfig ??= new OsuConfigManager(Storage);
}
private readonly List<ICanAcceptFiles> fileImporters = new List<ICanAcceptFiles>();