sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-02 22:26:41 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13929 from peppy/i-deep-cloneable

Browse Source 
Create a deep clone of score for score submission purposes
This commit is contained in:
Dan Balasescu
2021-07-19 21:58:27 +09:00
committed by GitHub
parent 23ef666f34 f16b4957aa
commit f3bcaf7f11
21 changed files with 118 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Screens/Play/Player.cs
View File

@ -184,7 +184,7 @@ namespace osu.Game.Screens.Play
[BackgroundDependencyLoader(true)]
private void load(AudioManager audio, OsuConfigManager config, OsuGameBase game)
{
Mods.Value = base.Mods.Value.Select(m => m.CreateCopy()).ToArray();
Mods.Value = base.Mods.Value.Select(m => m.DeepClone()).ToArray();
if (Beatmap.Value is DummyWorkingBeatmap)
return;
@ -694,9 +694,11 @@ namespace osu.Game.Screens.Play
/// <returns>The final score.</returns>
private async Task<ScoreInfo> prepareScoreForResults()
{
var scoreCopy = Score.DeepClone();
try
{
await PrepareScoreForResultsAsync(Score).ConfigureAwait(false);
await PrepareScoreForResultsAsync(scoreCopy).ConfigureAwait(false);
}
catch (Exception ex)
{
@ -705,14 +707,14 @@ namespace osu.Game.Screens.Play
try
{
await ImportScore(Score).ConfigureAwait(false);
await ImportScore(scoreCopy).ConfigureAwait(false);
}
catch (Exception ex)
{
Logger.Error(ex, @"Score import failed!");
}
return Score.ScoreInfo;
return scoreCopy.ScoreInfo;
}
/// <summary>