sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-30 01:47:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix code quality issues

Browse Source
This commit is contained in:
Dean Herbert 2023-01-26 15:43:03 +09:00
parent bcecc49092
commit f3c92749bf
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Skinning/LegacyJudgementPieceNew.cs
View File

@ -6,7 +6,6 @@ using osu.Framework.Graphics;
using osu.Framework.Graphics.Animations; using osu.Framework.Graphics.Animations;
using osu.Framework.Graphics.Containers; using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Textures; using osu.Framework.Graphics.Textures;
using osu.Framework.Utils;
using osu.Game.Graphics; using osu.Game.Graphics;
using osu.Game.Rulesets.Judgements; using osu.Game.Rulesets.Judgements;
using osu.Game.Rulesets.Scoring; using osu.Game.Rulesets.Scoring;
@ -17,7 +16,6 @@ namespace osu.Game.Skinning
public partial class LegacyJudgementPieceNew : CompositeDrawable, IAnimatableJudgement public partial class LegacyJudgementPieceNew : CompositeDrawable, IAnimatableJudgement
{ {
private readonly HitResult result; private readonly HitResult result;
private readonly decimal? version;
private readonly LegacyJudgementPieceOld? temporaryOldStyle; private readonly LegacyJudgementPieceOld? temporaryOldStyle;
@ -28,7 +26,6 @@ namespace osu.Game.Skinning
public LegacyJudgementPieceNew(HitResult result, decimal? version, Func<Drawable> createMainDrawable, Texture? particleTexture) public LegacyJudgementPieceNew(HitResult result, decimal? version, Func<Drawable> createMainDrawable, Texture? particleTexture)
{ {
this.result = result; this.result = result;
this.version = version;
AutoSizeAxes = Axes.Both; AutoSizeAxes = Axes.Both;
Origin = Anchor.Centre; Origin = Anchor.Centre;
@ -56,7 +53,7 @@ namespace osu.Game.Skinning
if (result != HitResult.Miss) if (result != HitResult.Miss)
{ {
//new judgement shows old as a temporary effect //new judgement shows old as a temporary effect
AddInternal(temporaryOldStyle = new LegacyJudgementPieceOld(result, this.version, createMainDrawable, 1.05f, true) AddInternal(temporaryOldStyle = new LegacyJudgementPieceOld(result, version, createMainDrawable, 1.05f, true)
{ {
Blending = BlendingParameters.Additive, Blending = BlendingParameters.Additive,
Anchor = Anchor.Centre, Anchor = Anchor.Centre,

2
osu.Game/Skinning/LegacyJudgementPieceOld.cs
View File

@ -58,7 +58,7 @@ namespace osu.Game.Skinning
this.ScaleTo(1.6f); this.ScaleTo(1.6f);
this.ScaleTo(1, 100, Easing.In); this.ScaleTo(1, 100, Easing.In);
if (this.version > 1) if (version > 1)
{ {
this.MoveTo(new Vector2(0, -5)); this.MoveTo(new Vector2(0, -5));
this.MoveToOffset(new Vector2(0, 80), fade_out_delay + fade_out_length, Easing.In); this.MoveToOffset(new Vector2(0, 80), fade_out_delay + fade_out_length, Easing.In);

4
osu.Game/Skinning/LegacySkin.cs
View File

@ -390,9 +390,9 @@ namespace osu.Game.Skinning
var particle = getParticleTexture(resultComponent.Component); var particle = getParticleTexture(resultComponent.Component);
if (particle != null) if (particle != null)
return new LegacyJudgementPieceNew(resultComponent.Component, this.Configuration.LegacyVersion, createDrawable, particle); return new LegacyJudgementPieceNew(resultComponent.Component, Configuration.LegacyVersion, createDrawable, particle);
return new LegacyJudgementPieceOld(resultComponent.Component, this.Configuration.LegacyVersion, createDrawable); return new LegacyJudgementPieceOld(resultComponent.Component, Configuration.LegacyVersion, createDrawable);
} }
return null; return null;