From f991448a3e6f359efa277f4491c472421c311ca9 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 24 Dec 2020 21:49:38 +0900
Subject: [PATCH] Re-sort the leaderboard order a maximum of once a second

---
 .../Screens/Play/HUD/GameplayLeaderboard.cs     | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Screens/Play/HUD/GameplayLeaderboard.cs b/osu.Game/Screens/Play/HUD/GameplayLeaderboard.cs
index cab1cbd3f1..e33cc05e64 100644
--- a/osu.Game/Screens/Play/HUD/GameplayLeaderboard.cs
+++ b/osu.Game/Screens/Play/HUD/GameplayLeaderboard.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Linq;
+using osu.Framework.Caching;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Game.Users;
@@ -12,6 +13,8 @@ namespace osu.Game.Screens.Play.HUD
 {
     public class GameplayLeaderboard : FillFlowContainer<GameplayLeaderboardScore>
     {
+        private readonly Cached sorting = new Cached();
+
         public GameplayLeaderboard()
         {
             Width = GameplayLeaderboardScore.EXTENDED_WIDTH + GameplayLeaderboardScore.SHEAR_WIDTH;
@@ -24,6 +27,13 @@ namespace osu.Game.Screens.Play.HUD
             LayoutEasing = Easing.OutQuint;
         }
 
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
+
+            Scheduler.AddDelayed(sort, 1000, true);
+        }
+
         /// <summary>
         /// Adds a player to the leaderboard.
         /// </summary>
@@ -41,7 +51,7 @@ namespace osu.Game.Screens.Play.HUD
             };
 
             base.Add(drawable);
-            drawable.TotalScore.BindValueChanged(_ => Scheduler.AddOnce(sort), true);
+            drawable.TotalScore.BindValueChanged(_ => sorting.Invalidate(), true);
 
             Height = Count * (GameplayLeaderboardScore.PANEL_HEIGHT + Spacing.Y);
 
@@ -55,6 +65,9 @@ namespace osu.Game.Screens.Play.HUD
 
         private void sort()
         {
+            if (sorting.IsValid)
+                return;
+
             var orderedByScore = this.OrderByDescending(i => i.TotalScore.Value).ToList();
 
             for (int i = 0; i < Count; i++)
@@ -62,6 +75,8 @@ namespace osu.Game.Screens.Play.HUD
                 SetLayoutPosition(orderedByScore[i], i);
                 orderedByScore[i].ScorePosition = i + 1;
             }
+
+            sorting.Validate();
         }
     }
 }