sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 08:20:00 +09:00
Code Issues Packages Projects Releases Wiki Activity

Test coverage + no virtual

Browse Source
This commit is contained in:
maromalo
2022-05-21 18:16:29 -03:00
parent 2bd4c126d3
commit fc25d248ad
2 changed files with 44 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayerMatchSubScreen.cs
View File

@ -178,6 +178,48 @@ namespace osu.Game.Tests.Visual.Multiplayer
.SingleOrDefault(panel => !panel.Filtered.Value)?.Mod is OsuModDoubleTime); .SingleOrDefault(panel => !panel.Filtered.Value)?.Mod is OsuModDoubleTime);
} }
[Test]
public void TestModSelectKeyWithAllowedMods()
{
AddStep("add playlist item with allowed mod", () =>
{
SelectedRoom.Value.Playlist.Add(new PlaylistItem(new TestBeatmap(new OsuRuleset().RulesetInfo).BeatmapInfo)
{
RulesetID = new OsuRuleset().RulesetInfo.OnlineID,
AllowedMods = new[] { new APIMod(new OsuModDoubleTime()) }
});
});
ClickButtonWhenEnabled<MultiplayerMatchSettingsOverlay.CreateOrUpdateButton>();
AddUntilStep("wait for join", () => RoomJoined);
AddStep("press toggle mod select key", () => InputManager.Key(osuTK.Input.Key.F1));
AddUntilStep("mod select contents loaded",
() => this.ChildrenOfType<ModColumn>().Any() && this.ChildrenOfType<ModColumn>().All(col => col.IsLoaded && col.ItemsLoaded));
}
[Test]
public void TestModSelectKeyWithNoAllowedMods()
{
AddStep("add playlist item with no allowed mods", () =>
{
SelectedRoom.Value.Playlist.Add(new PlaylistItem(new TestBeatmap(new OsuRuleset().RulesetInfo).BeatmapInfo)
{
RulesetID = new OsuRuleset().RulesetInfo.OnlineID,
});
});
ClickButtonWhenEnabled<MultiplayerMatchSettingsOverlay.CreateOrUpdateButton>();
AddUntilStep("wait for join", () => RoomJoined);
AddStep("press toggle mod select key", () => InputManager.Key(osuTK.Input.Key.F1));
AddAssert("mod select contents not loaded",
() => !(this.ChildrenOfType<ModColumn>().Any() && this.ChildrenOfType<ModColumn>().All(col => col.IsLoaded && col.ItemsLoaded)));
}
[Test] [Test]
public void TestNextPlaylistItemSelectedAfterCompletion() public void TestNextPlaylistItemSelectedAfterCompletion()
{ {

4
osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs
View File

@ -478,7 +478,7 @@ namespace osu.Game.Screens.OnlinePlay.Match
public class UserModSelectButton : PurpleTriangleButton, IKeyBindingHandler<GlobalAction> public class UserModSelectButton : PurpleTriangleButton, IKeyBindingHandler<GlobalAction>
{ {
public virtual bool OnPressed(KeyBindingPressEvent<GlobalAction> e) public bool OnPressed(KeyBindingPressEvent<GlobalAction> e)
{ {
if (e.Action == GlobalAction.ToggleModSelection && !e.Repeat) if (e.Action == GlobalAction.ToggleModSelection && !e.Repeat)
{ {
@ -489,7 +489,7 @@ namespace osu.Game.Screens.OnlinePlay.Match
return false; return false;
} }
public virtual void OnReleased(KeyBindingReleaseEvent<GlobalAction> e) { } public void OnReleased(KeyBindingReleaseEvent<GlobalAction> e) { }
} }
protected override void Dispose(bool isDisposing) protected override void Dispose(bool isDisposing)