sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-20 18:58:05 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4496 from smoogipoo/reinstantiate-mods

Browse Source 
Fix mods being reused for difficulty calculation
This commit is contained in:
Dean Herbert 2019-03-20 19:10:52 +09:00 committed by GitHub
commit fe255c54d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game/Rulesets/Difficulty/DifficultyCalculator.cs
View File

@ -37,6 +37,8 @@ namespace osu.Game.Rulesets.Difficulty
/// <returns>A structure describing the difficulty of the beatmap.</returns> /// <returns>A structure describing the difficulty of the beatmap.</returns>
public DifficultyAttributes Calculate(params Mod[] mods) public DifficultyAttributes Calculate(params Mod[] mods)
{ {
mods = mods.Select(m => m.CreateCopy()).ToArray();
beatmap.Mods.Value = mods; beatmap.Mods.Value = mods;
IBeatmap playableBeatmap = beatmap.GetPlayableBeatmap(ruleset.RulesetInfo); IBeatmap playableBeatmap = beatmap.GetPlayableBeatmap(ruleset.RulesetInfo);

5
osu.Game/Rulesets/Mods/Mod.cs
View File

@ -65,5 +65,10 @@ namespace osu.Game.Rulesets.Mods
/// </summary> /// </summary>
[JsonIgnore] [JsonIgnore]
public virtual Type[] IncompatibleMods => new Type[] { }; public virtual Type[] IncompatibleMods => new Type[] { };
/// <summary>
/// Creates a copy of this <see cref="Mod"/> initialised to a default state.
/// </summary>
public virtual Mod CreateCopy() => (Mod)Activator.CreateInstance(GetType());
} }
} }