10030 Commits

Author SHA1 Message Date
8908648f97 Fix super-dodgy cast of IEnumerable to Drawable 2023-03-15 18:01:22 +09:00
0a19b1e9cf Merge pull request #22860 from rozukke/fix-skin-ini-import
Fix import of skins with non-ASCII names that have been previously exported by lazer
2023-03-15 15:36:51 +09:00
1cf870d956 Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection 2023-03-15 15:16:48 +09:00
3c4e2d8700 Add tests covering drag selection 2023-03-14 21:04:51 +09:00
6546f5968a Merge branch 'master' into skin-editor-cyclic-selection 2023-03-14 20:43:56 +09:00
b5ea855b6c Fix failing DrawableRulesetDependencies test 2023-03-14 20:37:50 +09:00
969c0e9c9d Merge branch 'master' into veldrid-renderer 2023-03-14 17:35:38 +09:00
4570c0030f Add test to check for import of exported skin with non-ASCII name 2023-03-13 23:37:45 +11:00
c35c81293a Add test coverage ensuring images specified as videos are used as background image instead 2023-03-13 18:24:16 +09:00
3aea058c98 Add test coverage ensuring images are not read as videos 2023-03-13 18:24:16 +09:00
12f240e11a Apply simple NRT changes to touched test scenes 2023-03-13 18:24:16 +09:00
8e8dda3ac0 Big simplifying 2023-03-11 23:29:36 +01:00
15f11bb1e8 scorll container and save mod after popover hidden
Requires manual handling of many visual effects
2023-03-11 12:31:33 +09:00
b51c41a804 Addressed changes 2023-03-09 20:14:58 +01:00
f4e2620402 fix test 2023-03-10 00:56:22 +09:00
d009cd8422 test 2023-03-09 22:49:45 +09:00
d806b85a30 revert: make counters an IEnumerable again
As suggested by bdach as this would make the last two commits useless

Refs: 5d15426
2023-03-09 10:25:03 +00:00
ab87f5e0c9 Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name 2023-03-08 22:37:09 +01:00
44297a7d0a refactor: make KCD a CompositeDrawable 2023-03-08 00:47:16 +00:00
72695f7c90 Merge branch 'master' into omit-barline-in-timing-control-point 2023-03-07 22:46:24 +01:00
9ea93e0a9f Add more tests 2023-03-07 20:38:33 +01:00
cfafa8af8c Merge branch 'master' into hud/player-components 2023-03-07 19:44:12 +01:00
bedf4cc259 Remove extra code 2023-03-07 16:03:11 +01:00
5d41d343fd Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name 2023-03-07 15:46:52 +03:00
54564e0557 new design 2023-03-07 21:13:35 +09:00
28520414aa Move KeyCounter components to HUD namespace 2023-03-07 16:41:39 +09:00
15d65059b5 Tidy up Add method logic 2023-03-07 16:21:57 +09:00
8f6df5ea0f Merge branch 'master' into gameplay/key-counter-abstraction 2023-03-07 16:09:45 +09:00
d2fcdf6e0e Add test coverage of cyclic selection in skin editor 2023-03-07 15:11:47 +09:00
952814604e style: fix late night oopsies 2023-03-06 20:06:56 +00:00
0095fd85ca remove == true 2023-03-07 02:18:34 +09:00
4858d3fd42 Added ability to edit mod presets 2023-03-07 02:00:40 +09:00
ec15e2b9cc Merge branch 'master' into dont-filter-results-on-sort-mode 2023-03-06 17:57:47 +01:00
ddee6400df test: add coverage for Player{Avatar,Flag} 2023-03-05 23:46:51 +00:00
9d4bb2ecf7 Add failing test coverage for clearing sidebar contents 2023-03-04 14:08:50 +01:00
2f25fb4083 Move NonSkinnableScreenPlaceholder to outer scope 2023-03-04 13:22:43 +01:00
3dd3b5e77a Add failing test case 2023-03-04 13:17:54 +01:00
322f3e86ba Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name 2023-03-03 20:02:09 +03:00
a14dede036 Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.

Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995 Add better coverage and more comments explaining the structure of test setup 2023-03-03 17:18:14 +09:00
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
bd11d5d29a Merge pull request #22743 from Joehuu/scroll-back-to-previous
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
1250c1f0c1 Update test assertions to match stable expectations
These changes were taken from https://github.com/ppy/osu/pull/22582.

Minor adjustments were applied to match stable expectations, which is to
say there cannot be an inherited control point with omit barline
specification (in the editor the setting is greyed out when inheritance
is turned on).
2023-02-28 19:28:21 +09:00
2615453b31 Rename SettingSource tests to match attribute name 2023-02-28 11:45:32 +09:00
92edb0f868 Merge branch 'master' into skin-editor-depth-changing 2023-02-27 19:24:53 +01:00
fa710ae1b0 Rename ScrollToTopButton to ScrollBackButton 2023-02-26 14:39:34 -08:00
d98d330da2 Add expected behavior test for scroll back to previous position 2023-02-26 14:30:46 -08:00
dd9748a25c Adjust DrawNodes to use UBOs 2023-02-25 01:42:55 +09:00
09e7c21b23 Implemented a more complex setting conversion logic + tests 2023-02-24 15:11:22 +01:00
6307b3948a style: use Trigger initialisation 2023-02-22 17:59:39 +00:00