98 Commits

Author SHA1 Message Date
f7094567d7 Rename and document method to limit scope 2023-02-03 15:04:47 +09:00
500e9c7944 Refactor into a method rather than property 2023-02-02 14:53:58 +09:00
832d033777 Fix merge issues 2023-01-16 01:09:04 +01:00
ab6bf6e1dc Merge remote-tracking branch 'upstream/master' into carousel 2023-01-16 00:27:56 +01:00
87ee9ab813 Added custom menu items in DrawableCarouselBeatmap 2023-01-16 00:13:12 +01:00
69260ca3c3 remove unnecessary usages of nullable forgiveness, add asserts for debugging 2023-01-09 18:36:55 +01:00
47fb467012 Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
438067a18b Convert realm data propagation to more correctly use Live<T>
wip
2022-07-27 19:35:09 +09:00
41393616d8 Replace BeatmapCollection with RealmBeatmapCollection 2022-07-27 19:35:09 +09:00
9c543fef48 Remove CollectionManager 2022-07-27 18:45:33 +09:00
eaf4f6dbb7 Add beatmap update button 2022-07-19 18:29:36 +09:00
a94fb62be3 Split collection toggle menu item to own class 2022-07-08 01:39:45 +03:00
28837693e5 Nuke calculating everything
The whole component is pointless so I'm just going to nuke for now I
guess. Kind of makes the whole refactor effort pointless but oh well?

To expand on this, the implementation was actually incorrect as pointed
out at https://github.com/ppy/osu/pull/18819#pullrequestreview-1017886035.
2022-06-24 14:24:06 +09:00
01da6f20b3 Tidy up all remaining usages 2022-06-23 19:27:35 +09:00
7dec530ca5 Split out simple DifficultyIcon with no calculation overhead and update usages 2022-06-23 19:27:35 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
4a5e86e451 Rename Beatmaps to BeatmapHashes for clarity 2022-06-10 14:03:51 +09:00
42cd7d9e6e Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo 2022-06-08 18:23:09 +09:00
4b54fedd88 Add back hide common string using new ToSentence() extension method 2022-06-03 20:09:20 -07:00
999b4505d1 Remove localisation of "hide" string to fix incorrect case 2022-04-24 16:37:11 +09:00
5e5c8e78a6 Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
eb25730b61 Revert "Merge pull request #16716 from peppy/carousel-less-invalidations"
This reverts commit 8d13e0514b, reversing
changes made to 95582a9023.
2022-02-05 16:12:58 +09:00
c3e3b2019d Reduce overhead of ApplyState by tracking previous values
Even with pooling applied, there are overheads involved with transforms
when quickly cycling through the carousel.

The main goal here is to reduce the transforms in cases the reuse is
still in the same state. Avoiding firing `FadeIn` and `FadeOut` are the
main areas of saving.
2022-01-31 14:46:20 +09:00
a06287e76a Remove DrawableCarouselItem.Update updating of height
Marginal from a performance aspect, but reads better.
2022-01-31 14:46:20 +09:00
9be5bf38c6 Simplify binding/invalidation in TopLocalRank 2022-01-19 13:20:52 +09:00
3811bd8520 Fix some null inspections 2022-01-12 17:00:16 +09:00
213d89b479 Update null fallback cases involving OnlineID 2022-01-12 16:39:36 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
86540d1fb6 Update existing usages of Author as string to access Username directly 2021-11-04 18:57:54 +09:00
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
ec61c3c5ee Rename all remaining cases 2021-10-03 00:55:29 +09:00
973c31132b Rename BeatmapInfo variables which were named beatmap for clarity 2021-10-02 12:45:34 +09:00
03771ce8ec Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability 2021-02-25 16:19:01 +09:00
5113d4af8f Rename BeatmapDifficultyManager to BeatmapDifficultyCache 2020-11-06 13:14:29 +09:00
69650c16fc Simplify vertical position calculations by including spacing in height definition 2020-10-13 18:13:36 +09:00
f3b937e358 Fix masking issues with certain aspect ratio displays 2020-10-13 17:37:33 +09:00
cfec4f4fc1 Extract header element from base DrawableCarouselItem class 2020-10-13 17:37:33 +09:00
fd8654cff3 Add back difficulty panel spacing 2020-10-13 17:37:33 +09:00
5c29aa8cce Fix multiple difficulties being expanded at once 2020-10-13 17:37:33 +09:00
0a978c6131 Add basic pooling setup 2020-10-13 17:37:33 +09:00
3143224e5b Refactor how drawable carousel items are constructed 2020-10-13 17:37:33 +09:00
9193f5b0ba Expose panel height from non-drawable models 2020-10-13 17:37:33 +09:00
0360f7d845 Move CollectionManager to OsuGame 2020-09-09 15:39:15 +09:00
4ddf5f054b Rename BeatmapCollectionManager -> CollectionManager 2020-09-09 15:31:08 +09:00
a5e1e8d043 Rename More... to Manage... 2020-09-08 18:57:18 +09:00
ae022d7559 Show all items in dropdown, set global max height 2020-09-08 18:55:53 +09:00
8b770626fa Add missing '...' from some popup menu items 2020-09-08 12:18:08 +09:00
b15bbc882a Move items up in menu 2020-09-08 12:04:35 +09:00