7cc4fd4efc
Use the exact method stable uses for generating storyboard filenames
2023-01-26 15:09:36 +09:00
d15f8c2f3a
Fix beatmaps with multiple osb files potentially reading the storyboard from the wrong one
...
In stable, the storyboard filename is fixed. In lazer, we were always
looking for the first `.osb` in the database. In the case a beatmap
archive housed more than one `.osb` files, this may load the incorrect
one.
Using `GetDisplayString` here feels like it could potentially go wrong
in the future, so I'm open to hard-coding this locally (or using string
manipulation to remove the ` [creator_name]` portion of the beatmap's
filename). Open to opinions on that.
Fixes storyboard playback in https://osu.ppy.sh/beatmapsets/1913687#osu/3947758
2023-01-25 17:11:15 +09:00
902dff15e3
Add todo regarding validity check
2022-12-12 13:44:09 +09:00
b4e55f7309
Apply IRenderer changes
2022-08-02 19:50:57 +09:00
51071be315
Don't show "missing background" messages to user
...
Bit of an oversight.
As reported on [twitter](https://twitter.com/emyl___/status/1548627793075998720 ) and somewhere else i forgot.
2022-07-17 21:20:51 +09:00
e81cebf27d
Change storyboard parsing logic to not completely fail if only .osb read fails
...
Changes to allow the storyboard to exist if only the `.osu` is
available. Reads better IMO.
2022-07-07 14:33:20 +09:00
c4b6893709
Add local handling of cases where a beatmap's file cannot be found on disk
2022-07-07 14:29:19 +09:00
66a01d1ed2
Allow song select to refresh the global WorkingBeatmap after an external update
2022-06-24 21:02:38 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
e010dfb150
Handle virtual track string to avoid throwing later in lookup
2022-04-14 17:33:42 +09:00
a7f63fb034
Make providing a custom ResourceStore to LegacyBeatmapSkin optional (for tests only)
2022-03-23 14:57:42 +09:00
6eb2c28e41
Rename RealmContextFactory to RealmAccess
2022-01-24 20:38:07 +09:00
34aa1bf21d
Sanitise and remove some usages of Detach which are no longer required
2022-01-12 17:49:11 +09:00
c06b5951fd
Fix multiple remaining warnings
2022-01-12 17:49:11 +09:00
2ce80cc030
Add back caching in WorkingBeatmapCache
2022-01-12 17:49:11 +09:00
8461eaab46
BeatmapSetInfo detach support
2022-01-12 17:00:16 +09:00
3811bd8520
Fix some null inspections
2022-01-12 17:00:16 +09:00
33060990b7
Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows
2022-01-12 17:00:16 +09:00
b8cd3cdbbc
Various updates to ruleset and primary key usages to move closer to realm support
2022-01-12 16:57:13 +09:00
bc47801cbb
Revert "Apply NRT to WorkingBeatmap"
...
This reverts commit 9e17d7d4e3
2021-12-22 19:14:18 +09:00
9e17d7d4e3
Apply NRT to WorkingBeatmap
2021-12-22 18:41:45 +09:00
7344c87b16
Remove RecyclableLazy
2021-12-22 18:18:12 +09:00
f9a2db5ec6
Add accessibility to realm factory via IStorageResourceProvider
...
We might need to rename this class..
2021-12-14 14:19:49 +09:00
8ce5324c8b
Merge pull request #15772 from peppy/remove-model-list-inits
...
Initialise `BeatmapSet.Beatmaps` list at construction time
2021-11-24 16:41:19 +09:00
a7853fc9cc
Fix cases of known-non-null
2021-11-24 14:26:25 +09:00
729f681938
Update cases where equality can be used instead of primary key equality
2021-11-24 12:49:57 +09:00
3b485b5f37
Rewrite PreviewTrackManager to avoid constructing TrackBass locally
...
This paves the way for the framework code quality change
(https://github.com/ppy/osu-framework/pull/4873 ) which stops exposing
the constructor.
Most of the restructuring here is required to give `PreviewTrackManager`
an adjustable target to apply the global mute.
2021-11-09 17:38:12 +09:00
1e73b09e57
Fix another couple of cases of incorrect string null/empty checking
2021-11-04 14:22:28 +09:00
41854f2e16
Fix incorrect check on AudioFile presence
2021-11-04 14:02:09 +09:00
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
09536cd733
Add logging of WorkingBeatmapCache.Invalidate calls
2021-10-14 14:05:33 +09:00
1d99bc280f
Merge branch 'master' into new-interfaces
2021-10-04 20:42:40 +09:00
90225f2082
Hook up all required interfaces to new BeatmapManager
2021-09-30 17:18:39 +09:00
e7e0473323
Split out WorkingBeatmapCache from BeatmapManager
2021-09-30 15:40:41 +09:00
