Commit Graph

30814 Commits

Author SHA1 Message Date
ee5203f5bc Merge pull request #7968 from peppy/follow-point-performance
Improve gameplay performance via follow point renderer optimisations
2020-02-25 19:24:48 +09:00
36079236e6 Remove pointless comment
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-02-25 19:22:51 +09:00
29e2e17144 Merge branch 'master' into fix-dho-lifetimes-via-judgements 2020-02-25 19:07:57 +09:00
a047456354 Revert changes to make HitObject abstract 2020-02-25 19:07:15 +09:00
d6046abe70 Only expose save for now 2020-02-25 18:59:16 +09:00
b1686a264a Merge branch 'master' into fix-loading-animation 2020-02-25 18:42:22 +09:00
7e445c31b3 Merge branch 'master' into follow-point-performance 2020-02-25 18:40:39 +09:00
d11ec392f4 Merge pull request #7967 from peppy/judgement-line-performance
Reduce hit error display performance overhead
2020-02-25 18:33:37 +09:00
c1455be855 Add tests 2020-02-25 10:29:03 +03:00
f71c45cb1b Remove shallPropagate 2020-02-25 11:30:33 +09:00
d8413c558b Use fully qualified name for enum item description in CommentsHeader 2020-02-24 23:41:34 +03:00
a020566b1e Add HoverClickSounds 2020-02-24 23:37:46 +03:00
4cbb2a2f59 Move comment to more pertinent place 2020-02-24 21:30:27 +01:00
fe1f2858c1 Refactor to avoid duplicated code 2020-02-24 23:10:37 +03:00
6c28fd21c7 osu-side changes 2020-02-24 20:52:15 +09:00
7bc9a9b3d8 Implement OverlayPanelDisplayStyleControl and UserListToolbar components 2020-02-24 07:28:33 +03:00
e6cfafffe9 Fix incorrect LifetimeStart and add todo regarding Expire usage 2020-02-24 12:24:15 +09:00
b0b52146ea Fix crash when clicking on ShowMore button 2020-02-24 05:53:33 +03:00
0cfe1ac823 Implement UserSortTabControl component 2020-02-24 05:47:21 +03:00
71c34a36ed Use pattern matching instead of .(Has)?Value 2020-02-23 14:46:42 +01:00
575946d923 Expose save and export options in editor to non-dekstop platforms 2020-02-23 20:47:14 +09:00
be08e69862 Merge branch 'fix-dho-lifetimes-via-judgements' into fix-barline-lifetimes 2020-02-23 14:30:23 +09:00
401bf1c928 Remove unnecessary checks on NotNull attributes 2020-02-23 14:30:08 +09:00
0e29d3c4a2 Correctly expire bar lines in osu!taiko and osu!mania 2020-02-23 13:50:05 +09:00
ffc7eaa3f2 Fix hitobjects with unknown lifetimes by enforcing non-null judgement
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
74c7e29108 Apply suggestions 2020-02-23 01:22:37 +03:00
db7f29cc0e Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-retouch 2020-02-23 00:54:54 +03:00
0c3286fa5e Merge branch 'judgement-line-performance' into follow-point-performance 2020-02-23 05:36:22 +09:00
560cf21b12 Add lenience to comparison
Noticed that they could still stack up on maps with hitcircles at the same point in time (centipede).
2020-02-23 05:29:17 +09:00
4949977d7e Merge branch 'judgement-line-performance' into follow-point-performance 2020-02-23 05:14:21 +09:00
187770ee7d Merge branch 'fix-loading-animation' into follow-point-performance 2020-02-23 05:14:18 +09:00
beb18006da Show 0 pp if map is loved 2020-02-22 21:04:00 +01:00
aaa888a7c1 Adjust spin duration to make rotation more variable 2020-02-23 05:00:38 +09:00
8dbcdebd28 Use LoadingLayer at player loading screen 2020-02-23 05:00:08 +09:00
090d9d9350 Make FollowPointRenderer a LifetimeManagementContainer 2020-02-23 04:37:04 +09:00
cb9a7ee0bb Give FollowPointConnections a valid lifetime 2020-02-23 04:36:50 +09:00
e8ebb31517 Expire old judgement lines if too many exist 2020-02-23 03:53:51 +09:00
3daa49f1bd Clean up old judgement lines if too many are already present 2020-02-23 03:39:12 +09:00
5aa5a1bbdd Reduce transform time of judgement lines (visually looks almost the same) 2020-02-23 03:36:15 +09:00
66317f9fcd Merge pull request #7961 from bdach/log-location-in-issue-template
Rework issue templates
2020-02-23 01:13:45 +09:00
b8aef4ad4b Remove mobile issue template 2020-02-22 16:50:56 +01:00
f696724c1d Mention issue templates in README 2020-02-22 16:26:10 +01:00
ab3cc9ada4 Add log file location to issue templates 2020-02-22 16:25:00 +01:00
17d4757c3b Merge pull request #7950 from bdach/fix-direct-panel-scene
Fix regressed direct panel test scene
2020-02-22 22:22:32 +09:00
a512226036 Use attribute instead of CreateChildDependencies 2020-02-22 13:47:42 +01:00
c9d600b69c Show RankingsOverlay when clicking on charts button 2020-02-22 11:55:34 +01:00
63006e8672 Refactor to avoid visual inconsistency for beatmaps with no leaderboard 2020-02-22 03:40:59 +03:00
894b50f955 Basic implementation of BeatmapSetCommentsContainer 2020-02-22 03:24:50 +03:00
f248c0a98e Fix regressed direct panel test scene
Due to unnoticed past changes TestSceneDirectPanel has regressed in that
clicking the preview track button would crash due to an unregistered
IPreviewTrackOwner dependency.

Make the test scene itself implement that empty interface and cache
itself as IPreviewTrackOwner so that preview tracks lower down can
resolve the dependency.

As the test is purely visual and has no assertions, and the important
logic in that area (preview track playing logic) is already well-covered
enough elsewhere, no further changes were made.
2020-02-22 00:58:33 +01:00
44ddc585da Remove unused usings 2020-02-21 18:40:42 +03:00