fe414b942f
Ensure online play subscreen is loaded before forwarding OnExiting
...
Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a
framework issue; the framework correctly guards against this scenario,
see
4e29504384/osu.Framework/Screens/ScreenStack.cs (L277)
2021-07-20 15:51:34 +09:00
662822a40c
Avoid showing time of play on results screen when autoplay
...
Closes https://github.com/ppy/osu/issues/13940 .
2021-07-20 15:19:44 +09:00
6cc81c24b4
Merge pull request #13785 from ekrctb/dependency-providing-container
...
Add a convenient way to provide ad-hoc dependency to children in visual test
2021-07-20 14:18:17 +09:00
f415dc18a7
Merge pull request #13941 from Henry-YSLin/update-TargetBeatContainer
...
Update `OsuModTarget` to take advantage of the new `BeatSyncedContainer`
2021-07-20 12:30:49 +09:00
1c6a13fca7
Disallow mistimed event firing
2021-07-20 10:31:19 +08:00
a387d8df74
Use BeatSyncClock
2021-07-20 10:30:40 +08:00
9ea1f5900a
Don't consider version suffixes when checking for updates
...
This is just to make life easier for me with deploys for now.
2021-07-20 01:05:37 +09:00
e77597c2b6
Merge pull request #13921 from Game4all/localise-profile-overlay
...
Localise user profile overlay
2021-07-20 00:37:01 +09:00
844152e1b1
Merge pull request #13861 from peppy/add-password-support
...
Add multiplayer room password support
2021-07-19 23:32:28 +09:00
6e104fe084
Merge pull request #13894 from peppy/fix-beat-synced-container-alt
...
Fix multiple issues with `BeatSyncedContainer`
2021-07-19 23:19:20 +09:00
0fc1d3e404
Merge pull request #13931 from peppy/fix-replay-date
...
Fix replay dates being unexpectedly updated on play completion
2021-07-19 22:56:27 +09:00
9db5847344
Add test that a slider path is resampled when the path is edited
2021-07-19 22:53:32 +09:00
8586458704
Implement vertex deletion in juice stream selection blueprint
2021-07-19 22:53:32 +09:00
08f8d4e65e
Implement vertex addition in juice stream selection blueprint
2021-07-19 22:53:32 +09:00
01f5258a26
Add tests of juice stream selection blueprint
2021-07-19 22:53:32 +09:00
8cc1630655
Add initial juice stream editing
2021-07-19 22:53:32 +09:00
6a55cb9df0
Revert unintended change
...
It's a deeper issue with ScreenStack (see:
https://github.com/ppy/osu-framework/issues/4619 ).
2021-07-19 22:52:07 +09:00
7956f73f62
Move initial content into step
2021-07-19 22:31:53 +09:00
57a99886d5
Fix password icon not disappearing when no password
2021-07-19 22:31:01 +09:00
892d858d5f
Fix compile error
2021-07-19 22:23:31 +09:00
b7c2d6b1ab
Merge branch 'master' into add-password-support
2021-07-19 22:23:09 +09:00
6d49165664
Merge pull request #13928 from ekrctb/juice-stream-path
...
Add `JuiceStreamPath` as alternative representation of `JuiceStream` path for catch editor
2021-07-19 22:18:05 +09:00
5ef1fe6948
Merge branch 'master' into fix-replay-date
2021-07-19 21:58:37 +09:00
f3bcaf7f11
Merge pull request #13929 from peppy/i-deep-cloneable
...
Create a deep clone of score for score submission purposes
2021-07-19 21:58:27 +09:00
0a43e54dfc
Fix request failing due to parameters
2021-07-19 21:24:22 +09:00
81d0a9bd9c
Fix item ordering
2021-07-19 21:05:36 +09:00
a001e4aa16
Fix web request failing if password is null
2021-07-19 20:57:16 +09:00
05295241b8
Add room joining tests
2021-07-19 20:55:14 +09:00
3168a927dc
Fix possible exception
2021-07-19 20:50:30 +09:00
80c2b1449b
Fix API request potentially firing failed events after completion
...
Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.
This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.
Closes https://github.com/ppy/osu/issues/13632 .
2021-07-19 20:27:01 +09:00
41169fbdaf
Add [NotNull]
2021-07-19 20:20:10 +09:00
2eec524f27
Fix password not copied from multiplayer client
2021-07-19 20:20:08 +09:00
d6aa15e5d7
Remove local APIRoom from test multiplayer client
2021-07-19 20:19:23 +09:00
7201cfe0b4
Move child drawable creation of CatchPlayfield from constructor to load.
2021-07-19 20:18:17 +09:00
879467961f
Fix catcher trails displayed in wrong place
2021-07-19 20:13:31 +09:00
b88ee3c1a1
Pass DroppedObjectContainer via constructor instead of DI
...
It is now just one level deep, so it is not beneficial to use DI here.
This effectively reverts ae09c23e
2021-07-19 20:11:49 +09:00
1b9d297911
Add test
2021-07-19 20:08:29 +09:00
a5a0f12e19
Also copy password in test room manager
2021-07-19 20:07:56 +09:00
26d0eea485
Set HasPassword correctly in the response room
2021-07-19 20:03:32 +09:00
2515785f93
Use room password to fill settings textbox
2021-07-19 20:03:32 +09:00
8c0daa89a0
Make test multiplayer client validate password
2021-07-19 20:03:27 +09:00
063f14da98
Update test room manager to not return passwords
2021-07-19 20:03:27 +09:00
50f9e5f362
Replace usage of CatcherArea.MovableCatcher with Catcher
2021-07-19 19:52:40 +09:00
97059a9f50
Create Catcher in CatchPlayfield
2021-07-19 19:44:40 +09:00
b3f60c8253
Fix date being updated on replays unexpectedly
2021-07-19 19:28:35 +09:00
f16b4957aa
Move clone to earlier in the process
2021-07-19 19:18:34 +09:00
23ef666f34
Merge pull request #13887 from ekrctb/legacy-converted-y
...
Preserve Y position of hit objects in osu!catch
2021-07-19 18:48:23 +09:00
f1f6af88a1
Merge pull request #13926 from peppy/set-rank-on-failed-submission
...
Set score's rank on a failed submission
2021-07-19 18:45:21 +09:00
443058f879
Move playfield constant to top of file and make internal
2021-07-19 18:41:29 +09:00
473011070f
Merge pull request #13908 from peppy/editor-disallow-placement-when-untimed
...
Fix editor composer allowing object placement without timing present
2021-07-19 18:37:19 +09:00
