010720de74
Factor out general file presence checking
...
This allows us to use the same method of checking for other files that should exist, for example the audio file.
By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
56bf49c85c
Take IWorkingBeatmap instead of WorkingBeatmap
...
This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.
2021-04-18 01:21:20 +02:00
abf512532e
Clean up check logic
...
Makes use of the new `BeatmapSet.GetPathForFile` method and removes dependency on `WorkingBeatmap` specifically, allowing us to switch to `IWorkingBeatmap` later.
2021-04-18 01:19:25 +02:00
cb41c89935
Don't return low res and too low res at the same time
2021-04-17 20:10:07 +02:00
62c54e00cb
Add check for background resolution and filesize
2021-04-17 18:01:04 +02:00
448574e7e6
Use WorkingBeatmap instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
cb4f64133e
Add xmldoc to interfaces
2021-04-13 23:30:20 +09:00
69da804f81
Add missing period
2021-04-13 13:57:56 +02:00
6d3f9fa9ce
Use is class instead of Equals with template index
...
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
d8088777ea
Add Equals method to IssueTemplate
...
This will be useful in tests.
2021-04-13 01:21:34 +02:00
19a154ddf1
Rename checkOrigin -> check
...
More consistent with `Issue.ctor`'s "template".
2021-04-12 17:28:12 +02:00
bb720c23a0
Remove check ctors and locals
2021-04-12 17:12:37 +02:00
62c1812282
Remove redundant parameter naming
2021-04-12 23:37:47 +09:00
36bd235021
Move nested classes to bottom of file
2021-04-12 23:36:10 +09:00
6d50d01186
Make IssueTemplate.Check readonly
2021-04-12 16:23:05 +02:00
caaaba5950
Rename Check -> ICheck
2021-04-12 16:20:53 +02:00
008dbc7dd6
Reverse IssueType ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
7c4f6d2b62
Rework template usage
...
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
65ebdd8f7a
Move check origin from IssueTemplate to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
78bbc8f5c8
Tidy some remaining code
2021-04-12 15:52:18 +09:00
8c31e96cdf
Change some methods to get properties
2021-04-12 15:52:18 +09:00
f78239c7f2
Move enums out of nesting
2021-04-12 15:52:18 +09:00
3551322f1d
Fix formatting of colour getter
2021-04-12 15:52:18 +09:00
257acf9cd8
Colour constants to private
2021-04-12 15:52:18 +09:00
136627b9ac
Wrap xmldoc less and make a few fixes
2021-04-12 15:52:18 +09:00
3289bb0379
Merge Check and BeatmapCheck
...
We're probably not going to need GeneralChecks or BeatmapsetChecks.
The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
bc4f3351f3
Replace checks with realistic ones
2021-04-10 13:03:16 +02:00
d1007ff26a
Move components to more appropriate spot
2021-04-10 13:02:22 +02:00
