3b485b5f37
Rewrite PreviewTrackManager to avoid constructing TrackBass locally
...
This paves the way for the framework code quality change
(https://github.com/ppy/osu-framework/pull/4873 ) which stops exposing
the constructor.
Most of the restructuring here is required to give `PreviewTrackManager`
an adjustable target to apply the global mute.
2021-11-09 17:38:12 +09:00
2b518035da
Merge pull request #15522 from bdach/taiko-slider-multiplier-saving
...
Fix taiko beatmap scroll speed increasing after every save in editor
2021-11-08 22:51:43 +09:00
74603253d2
Store full model rather than online ID only
2021-11-08 13:42:56 +01:00
72489b32f9
Move toggle code into own method for readability
2021-11-08 21:39:16 +09:00
9a2425f316
Remove unused field for now to appease inspectcode
2021-11-08 21:36:28 +09:00
540b7e1b38
Fix taiko editor not unapplying slider multiplier changes on save
2021-11-08 13:28:42 +01:00
f4b8dee2d0
Update favourite statistic value on favourite button clicks
2021-11-08 11:53:54 +01:00
b5cbdcf981
Implement basic behaviour of favourite button
2021-11-08 11:53:54 +01:00
0faa26fc13
Add basic structure for buttons
2021-11-08 11:53:53 +01:00
8b85c2c8de
Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events
...
Revert weird event flow in model manager/importers
2021-11-08 15:19:58 +09:00
a2dfb5fd8c
Merge pull request #15513 from bdach/beatmap-card/statistics
...
Add statistics display to beatmap card
2021-11-08 14:45:56 +09:00
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
1589b50d6e
Merge branch 'master' into beatmap-card/statistics
2021-11-08 13:28:31 +09:00
fb495d77ce
Implement TooltipText directly
2021-11-08 13:22:57 +09:00
0e09edfce2
Do not show nomination info if hype info not present to match web
2021-11-07 21:33:42 +01:00
1f405a7e71
Display extended statistics on card hover
2021-11-07 21:33:41 +01:00
c0b5b0e909
Add new statistic types to online info
2021-11-07 21:33:41 +01:00
04c2a9cd59
Display basic statistics on card hover
2021-11-07 21:03:06 +01:00
f0809801c5
Update remaining actions to events
2021-11-07 11:34:37 +09:00
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
89cc2523ef
Fix incorrectly specified events
2021-11-06 22:31:49 +09:00
2881ce0f5a
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-06 14:08:39 +09:00
9a7c75508e
Merge branch 'master' into user-class-cleanup
2021-11-05 19:56:18 +09:00
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
6c385ccd29
Move second generic to abstract model downloader rather than interface type
2021-11-05 17:37:05 +09:00
1fe9bca819
Change ModelDownloader's requirement to an IModelImporter rather than IModelManager
2021-11-05 16:47:18 +09:00
b90f44493c
Remove importer inheritance from IModelManager
...
Now only exists in legacy implementations, to reduce inheritance
complexity of interfaces which are going to be used going forwards.
2021-11-05 16:45:38 +09:00
ed07ee8c61
Update all existing usages of AuthorString/AuthorId
...
Unfortunately the getters need to be left in place else EF breaks.
2021-11-04 18:59:37 +09:00
86540d1fb6
Update existing usages of Author as string to access Username directly
2021-11-04 18:57:54 +09:00
7547810979
Change IBeatmapMetadataInfo.Author to be an IUser
2021-11-04 18:32:42 +09:00
b9983add15
Rename User to APIUser and move to correct namespace
2021-11-04 18:21:31 +09:00
4b1b92cde6
Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages
2021-11-04 15:23:04 +09:00
9c926e5514
Remove BeatmapSetInfo.OnlineInfo and all usages
2021-11-04 15:23:04 +09:00
0d0eab90bc
Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info
2021-11-04 15:23:02 +09:00
84d36cbae7
Add fallback for cases where BeatmapSet may be null
...
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
a49366ff84
Remove nullability from IBeatmapInfo.Metadata
2021-11-04 14:28:39 +09:00
1e73b09e57
Fix another couple of cases of incorrect string null/empty checking
2021-11-04 14:22:28 +09:00
41854f2e16
Fix incorrect check on AudioFile presence
2021-11-04 14:02:09 +09:00
67d9590a79
Fix new inspections
2021-11-04 14:02:09 +09:00
772b6c6dcd
Enable nullable support on BeatmapMetadata
2021-11-04 12:11:42 +09:00
ca438a102d
Fix beatmap paths including invalid slash/backslash characters
2021-11-03 16:46:05 +09:00
cf7545e36c
Merge branch 'master' into beatmap-card-basics
2021-11-03 00:11:03 +01:00
1813681fac
Move private method below protected
2021-11-03 00:10:50 +01:00
75e89f17ad
Rewrite BeatmapCardContentBackground
2021-11-03 00:07:03 +01:00
5ea901da2e
Merge pull request #15429 from peppy/fix-beatmap-download-notifications
...
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 04:36:59 +09:00
392559ae3e
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 03:23:41 +09:00
6efd3d3115
Don't perform background difficulty calculation for multiplayer panels
...
There are cases these are shown in a long list. They shouldn't be
running calculations.
2021-11-03 03:12:52 +09:00
08b0ffad50
Fix incorrect check for local beatmap in BeatmapDifficultyCache
...
This was correct in the WIP branch I have, but pulled out alone (where
usages of `ToBeatmapInfo` still exist) it was not enough.
2021-11-03 03:12:52 +09:00
15c770e155
Remove no longer used Section.None
2021-11-02 14:01:41 +09:00
ab28948744
Default legacy decoder to General section, rather than none
...
This is mainly to reach parity with how stable handles such cases for
skins specifically. It was brought to our attention after finding a skin
with a malformed `\[General]` tag which did not break further parsing of
the file on stable, but did on lazer.
Note that stable defaults to an "unknown" section for beatmaps, but
functionally I can't think of a regression case from changing this to a
"general" default.
2021-11-02 13:59:13 +09:00
