Commit Graph

48157 Commits

Author SHA1 Message Date
dea2e1fac0 Return immediately on failed web request in synchronous BeatmapOnlineLookupQueue flow 2022-01-14 13:20:51 +09:00
8424d86e9a Remove unused cancellationToken parameter in synchronous BeatmapOnlineLookupQueue flow 2022-01-14 13:19:00 +09:00
9b33fbbee5 Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo 2022-01-14 13:08:20 +09:00
9936cdbd65 Merge pull request #16443 from nekodex/fail-volume-dip
Add volume dip to track during fail sequence
2022-01-14 12:31:22 +09:00
55b027228f Update resources 2022-01-14 11:54:50 +09:00
eb5f15a77e Merge pull request #16420 from bdach/slider-paste-parsing-failures-2
Fix pasted sliders having sample points with time at infinity
2022-01-13 23:28:49 +09:00
54804ebfbd Fix delete/clear scores buttons not working 2022-01-13 18:38:38 +09:00
c33fe7bcc6 Remove one more unnecessary Detach operation 2022-01-13 18:32:59 +09:00
c6ae255326 Add volume dip to track during fail sequence 2022-01-13 18:31:32 +09:00
2840a71dda Uncomment EF deletion lines in migrations 2022-01-13 18:28:00 +09:00
4f8d29c1c0 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-13 18:25:09 +09:00
b610d2db12 Add EF to realm beatmap migration 2022-01-13 18:23:18 +09:00
45a23e5a43 Add EF to realm score migration 2022-01-13 18:23:18 +09:00
ded1d87739 Move RulesetStore construction earlier in process so rulesets are available for EF migration 2022-01-13 18:23:18 +09:00
069d6d2954 Remove pointless compatibility parameter BeatmapSetInfoID 2022-01-13 18:02:10 +09:00
4012ef7e7b Reduce polling rate when idle even if HighPollRate is requested 2022-01-13 17:33:55 +09:00
46d2f305b5 Log chat polling rate changes 2022-01-13 17:31:59 +09:00
0bd34253e7 Increase chat polling rate during multiplayer lobby / games 2022-01-13 17:31:49 +09:00
2de0c34bc9 Reduce exposure of ChannelManager 2022-01-13 17:10:48 +09:00
7147799895 Merge pull request #16273 from Joehuu/fix-remaining-identifier-names
Normalise more identifier names
2022-01-13 17:06:57 +09:00
c61419dfe5 Fix scores not using correct filename/display strings
I've updated all cases where we should have been using
`GetDisplayString()` anyway, but left the `ToString()` implementations
in place for safety. They should probably be removed in the future.
2022-01-13 16:56:11 +09:00
93c78253d6 Add synchronous fetch flow to BeatmapOnlineLookupQueue
The async flow doesn't work great with the realm import process. We
might be able to improve on this going forward, but for the time being
adding a synchronous path seems safest.

After all, we are already an an asynchronous (dedicated) thread pool at
this point.
2022-01-13 16:36:54 +09:00
bdb2979b2e Remove async from Populate method 2022-01-13 16:36:54 +09:00
70c107b434 Remove pointless override method in RealmArchiveModelManager 2022-01-13 16:27:12 +09:00
88145dedf1 Remove oudated comments 2022-01-13 15:27:43 +09:00
6025fe325d Fix filter criteria not being applied after carousel loads new beatmap sets 2022-01-13 15:08:51 +09:00
0a133c7e97 Fix typo in comment in IntroScreen 2022-01-13 13:47:23 +09:00
dcc354aa7c Fix deleted scores not being cleaned up on next startup 2022-01-13 13:40:09 +09:00
7a81fe19f6 Bump realm schema version to allow upgrades 2022-01-13 13:28:46 +09:00
b77cb344d5 Use ctor rather than MemberwiseClone to guarantee a safer clone of BeatmapDifficulty 2022-01-13 13:23:41 +09:00
86b2ac3217 Remove unnecessary Ruleset null check in BeatmapDifficultyCache 2022-01-13 13:19:49 +09:00
7baff18764 Add back PerformRead return safety by checking IsManaged status of returned data 2022-01-13 13:14:44 +09:00
085893c9b4 Fix stray bracket 2022-01-13 13:03:57 +09:00
65dd80e6f6 Sanitise mods / statistics cache logic in ScoreInfo 2022-01-13 12:59:16 +09:00
1a29098f3b Change default value and add comment explaining why skins are never "locally available" 2022-01-13 12:50:18 +09:00
ebe8ba3c3c Fix unintended change to dotsetting 2022-01-13 12:47:11 +09:00
e1f5acd689 Remove names from user dictionary 2022-01-13 12:40:19 +09:00
24f02cab8a Merge pull request #16436 from smoogipoo/fix-intermittent-tests 2022-01-13 09:45:22 +09:00
a18b283626 Revert identifier typo bump 2022-01-12 15:52:33 -08:00
66773f6d7d Use comments to disable identifier typos instead 2022-01-12 15:49:28 -08:00
5185f6010e Fix missed identifier typos 2022-01-12 15:46:20 -08:00
b245ffefc1 Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names 2022-01-12 15:05:07 -08:00
672c1d36dc Fix intermitten screen navigation tests 2022-01-13 05:52:04 +09:00
afce976f08 Fix oversubscription to StartTimeBindable.ValueChanged 2022-01-12 19:29:49 +01:00
07fc772c24 Merge branch 'master' into slider-paste-parsing-failures-2 2022-01-12 19:06:36 +01:00
6b7896ec69 Merge pull request #16434 from peppy/fix-being-playing-test-failures
Fix test failures due to double `BeginPlaying` calls
2022-01-13 02:43:42 +09:00
2212bea17f Fix test failures due to double BeginPlaying calls 2022-01-13 01:34:29 +09:00
4c79145c11 Fix potential mod nullref in APIUserScoreAggregate's CreateScoreInfo implementation 2022-01-13 00:28:16 +09:00
b2d09b7b10 Fix further warnings 2022-01-12 23:42:12 +09:00
b5f670cc5b Add far too many fixes for ruleset non-nullable requirements 2022-01-12 23:24:11 +09:00