e9187cc3cf
Add failing test showing expanded state being unexpectedly lost
2021-12-15 16:26:19 +09:00
b326ccc196
Move logic to framework and update all usages
2021-12-15 07:13:24 +01:00
828072bcea
Fix issue #15869
...
The taiko-slider is not included in `Playfield`, so it doesn't get hidden when calling `drawableRuleSet.Playfield.Hide()`. Calling `drawableRuleSet.Hide()` hides the taiko-slider, in addition to the rest of the `Playfield`.
2021-12-14 23:23:11 -05:00
0c11fe7413
Fix toast popups spamming samples when adjusting osu!mania scroll speed during gameplay
...
Not the most robust of fixes, but as per the reasoning described in the
issue thread, a proper fix will take considerably more effort. This
intends to fix the issue first and foremost, as it sounds so bad I'd
want to mute my sound before adjusting currently.
Closes #15718 .
2021-12-15 12:45:23 +09:00
6bffeb6a24
Merge branch 'master' into fix-autopilot-touch-devices
2021-12-15 12:04:35 +09:00
9d85beddbe
Fix null reference in some tests due to missing realm context factory
2021-12-15 11:16:37 +09:00
01ca9eb81c
Merge pull request #16072 from rumoi/rhythm-bonus-performance-fix
...
Eliminate iterations with no effect from rhythm bonus calculation
2021-12-15 09:57:25 +09:00
e662a9f0c4
Remove redundant code.
2021-12-15 12:36:45 +13:00
2cea39a92a
Merge pull request #16083 from peppy/fix-online-availability-after-reimport
...
Fix `OnlinePlayBeatmapAvailabilityTracker` failng after modified reimport of existing beatmap
2021-12-15 08:31:02 +09:00
ee6f125948
Merge pull request #15967 from tbrose/chat-mention-fix
...
Check word boundaries during username mention matching
2021-12-15 08:04:39 +09:00
da00c020be
Remove whitespace
2021-12-15 07:33:49 +09:00
9ade8069a1
Rename to AbortGameplay() and handle additional states
2021-12-15 06:40:28 +09:00
4c81fd8b7c
Merge pull request #16068 from peppy/fix-fail-animation-background-dim
...
Improve appearance of player-wide background after failing with low background dim
2021-12-15 06:32:02 +09:00
e862b3775b
Merge pull request #16081 from peppy/fix-menu-background-desync
...
Fix `BackgroundScreenDefault` incorrectly updating current background after being inactive
2021-12-14 22:01:31 +01:00
00154fe86d
Merge branch 'master' into fix-menu-background-desync
2021-12-14 21:31:10 +01:00
74ea10179d
Merge branch 'rhythm-bonus-performance-fix' of https://github.com/rumoi/osu into rhythm-bonus-performance-fix
2021-12-15 05:16:34 +13:00
4664bb1d29
Remove uneeded complexity
2021-12-15 05:16:10 +13:00
a831744f05
Merge remote-tracking branch 'origin/chat-mention-fix' into chat-mention-fix
2021-12-14 16:24:05 +01:00
8e79fac389
Fixes code quality check failed
2021-12-14 16:23:51 +01:00
0950d8d327
Add back PlaylistRoomCreation test
...
Was spiritually removed in https://github.com/ppy/osu/pull/16045 .
This implementation is mostly taken from that PR's comment thread
verbatim, and now works due to the associated changes to
`OnlinePlayBeatmapAvailabilityTracker`.
2021-12-14 19:16:52 +09:00
453ecd21b3
Fix OnlinePlayBeatmapAvailabilityTracker potentially in incorrect state
...
Adter an import of a modified version of a beatmap (that was already
present in the local database), it's feasible that one of these trackers
would not see the state change due to the nuances of the import process.
2021-12-14 19:16:11 +09:00
3bc2de4889
Add failing test coverage of modified beatmap import breaking online availability state
2021-12-14 19:11:23 +09:00
04551ea61e
Merge pull request #16080 from smoogipoo/fix-storyboard-start-time
...
Fix incorrect storyboard life time start with looping commands
2021-12-14 18:33:56 +09:00
cebfeb5220
Merge pull request #16045 from smoogipoo/multiplayer-local-beatmap-query
...
Rework multiplayer's current item tracking
2021-12-14 18:33:30 +09:00
79dd9674fc
Use longer form to read better
...
Using `l.StartTime` reads like a coding issue, even though if you go
down the call chain looks to be correct.
2021-12-14 17:41:09 +09:00
8c6f50ddb1
Fix BackgroundScreenDefault incorrectly updating current background after being inactive
...
If the beatmap was changed but then reverted to the previously displayed
map, the background may have displayed incorrectly on resuming.
Closes #15804 .
2021-12-14 16:40:50 +09:00
25a056dfad
Remove pointless/broken test steps
...
These aren't accurate and are tested via a more accurate means directly
above.
2021-12-14 16:40:50 +09:00
b6a272e31a
Add failing test coverage of BackgroundScreeNDefault's beatmap background tracking when active/non-active
2021-12-14 16:40:34 +09:00
eb3050b2ac
Fix incorrect test
2021-12-14 15:08:00 +09:00
441b7baa93
Provide a realm factory to usages of ToLive/RealmLive
2021-12-14 14:26:34 +09:00
f9a2db5ec6
Add accessibility to realm factory via IStorageResourceProvider
...
We might need to rename this class..
2021-12-14 14:19:49 +09:00
be337b4ace
Add failing test coverage of RealmLive failing post storage migration
2021-12-14 13:53:23 +09:00
8e6c7eb030
Use OsuStorage in realm tests to allow for migration
...
Also changes the realm filename to use `client` to match the ignore
rules in `OsuStorage`. Without doing this, migration will fail in an
indefinite mutex wait when attempting to delete the realm `.note` file.
2021-12-14 13:52:28 +09:00
7e576ae9d3
Add note about how the background colour is restored
2021-12-14 13:25:19 +09:00
357a661379
Fix storyboard sprites sometimes starting too early
2021-12-14 13:13:12 +09:00
51b6b9d857
Merge branch 'master' into chat-mention-fix
2021-12-14 11:49:57 +09:00
750bfae909
Fix TestMultiplayerClient not handling all users bailing from gameplay
2021-12-14 11:35:56 +09:00
2f1dc91211
Add AbortLoad() method to abort gameplay loads
2021-12-14 11:30:42 +09:00
a076eda834
Merge pull request #16062 from smoogipoo/retry-score-submission-timeout
...
Increase score submission timeout
2021-12-14 11:03:20 +09:00
19f7f4dc02
Merge pull request #16070 from peppy/test-score-refactoring
...
Move test `ScoreInfo` creation to `TestResources`
2021-12-14 10:03:52 +09:00
419a34e7b4
Merge branch 'master' into test-score-refactoring
2021-12-14 07:30:06 +09:00
01c7ff71c2
Merge pull request #16069 from peppy/clean-up-excess-bindings
...
Refactor `KeyBindingStore` to clean up any excess bindings for individual actions
2021-12-14 06:48:08 +09:00
7564658b5e
Reduce to 30s
2021-12-14 06:40:45 +09:00
6e3558b222
Remove weird test
2021-12-14 06:38:57 +09:00
5618bdafce
Merge branch 'master' into rhythm-bonus-performance-fix
2021-12-14 09:40:37 +13:00
c87ff82c1c
calculateRhythmBonus performance fix.
2021-12-14 09:25:29 +13:00
9e9341597d
Remove unused using statement
2021-12-13 17:59:04 +09:00
309290a3c9
Use new method in more places that can benefit from it
2021-12-13 16:56:43 +09:00
654b47c7ec
Move "excess mods" test behaviour to local usages
...
There were only two of these, so it doesn't make sense to add extra
complexity in the test resources class.
2021-12-13 16:41:30 +09:00
99ac71c1fe
Simplify usages where the ruleset being used is osu! ruleset
2021-12-13 16:37:20 +09:00
