c6ee4e900e
Ensure a non-null hitobject entry has a non-null Result
2021-04-20 15:18:36 +09:00
8a8b9084ef
Make single-argument overloead of DHO.Apply public
2021-04-20 10:11:36 +09:00
1bc63a4c61
Now, DHO.lifetimeEntry can be non-null even it is not fully applied
2021-04-20 09:22:16 +09:00
c1b4aaaa03
Add doc comment
2021-04-20 08:38:02 +09:00
2c487ddb70
Create synthetic LifetimeEntry for a DHO when not supplied
...
Now, a DHO is always associated with a HitObjectLifetimeEntry while used.
Result is always stored in the entry, and not in the DHO.
2021-04-19 21:54:19 +09:00
5afdc3ff66
Make DHO application logic clearer with Entry/HitObject separation
2021-04-19 19:56:17 +09:00
d38e294d96
Centralise length validation function
2021-04-16 15:45:24 +09:00
50fad47ebc
Remove usage of Lazy<List<...>> for NestedHitObjects
2021-04-15 18:26:01 +09:00
b5954a55ad
Remove empty <returns> xmldoc
2021-04-12 17:46:14 +09:00
76981f2547
Remove unused using
2021-04-09 13:58:24 +09:00
8293b06c0a
Remove obsolete code
2021-04-09 13:56:58 +09:00
a8839792fd
Merge branch 'master' into circular-arc-freeze
2021-04-08 14:33:03 +09:00
4b29d0ebe2
Fix last control point starting new segment
2021-04-05 17:49:36 +09:00
7b684339ed
Undo public -> internal for PathControlPoint.Changed
...
No longer used.
2021-03-31 20:32:49 +02:00
4ae3eaaac6
Move path type correction
...
This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.
2021-03-24 03:02:19 +01:00
e922e67c98
Fix inverted return statement
...
Forgot to run tests, all passing now.
2021-03-22 19:48:21 +01:00
3fa5852e00
Add method documentation
2021-03-22 19:42:27 +01:00
b11fd7972a
Separate condition logic from math logic
2021-03-22 19:41:48 +01:00
92f713a30e
Improve fallback conditions
...
It's possible to create a `PerfectCurve` type path with more than 3 points currently, so this accounts for that.
2021-03-22 19:10:56 +01:00
80e7c3aba7
Invert if statement
2021-03-22 19:09:28 +01:00
6911a1b415
Fix missing newline
2021-03-22 19:03:55 +01:00
a7076c329c
Fix null checks
2021-03-22 17:32:55 +01:00
323b875cea
Fix newlines/spaces
2021-03-22 17:32:40 +01:00
c82218627f
Add path type update logic
...
Only attempts to change points to bezier if points in the slider are modified.
2021-03-22 15:57:57 +01:00
7a2cb526e4
Add PointsInSegment method
2021-03-22 15:55:30 +01:00
bee2f55d00
Undo subpath limiting
2021-03-22 15:54:33 +01:00
fcd1f4930f
Fix freeze due to large circular arc radius
...
Seems to stem from the osu!framework's PathApproximator not catching a few edge cases wherein the radius approaches infinity.
2021-03-21 06:34:55 +01:00
dff1d80f39
Update HasFlag usages to HasFlagFast
2021-02-25 15:38:56 +09:00
9cc63e8dce
Remove obsoleted IHasEndTime
2021-01-06 18:38:24 +01:00
539785e422
Remove obsoleted IHasCurve
2021-01-06 18:38:24 +01:00
09742998cd
Fix mistaken obsoletion notice
...
It was added in c9f38f7bb6
2021-01-06 18:38:24 +01:00
a31e8d137f
Add guard when clearing samples
2020-12-20 15:42:24 +01:00
a0f92628ac
Merge branch 'master' into fix-sample-expire
2020-12-04 13:49:08 +09:00
5ded4b9faa
Merge branch 'master' into dho-remove-onparentreceived
2020-12-04 11:04:56 +09:00
0bdf99b97a
Remove OnParentReceived()
2020-12-03 20:08:42 +09:00
73e99718bc
Change order of OnParentReceived()
2020-12-03 20:06:26 +09:00
6c46046c24
Fix DHO expires while hit sound is playing
2020-12-03 12:32:49 +09:00
e831c797f3
Merge branch 'master' into hit-sample-pooling
2020-12-02 14:45:24 +09:00
2150cf1c52
Rename parameters
2020-12-02 10:55:48 +09:00
e19ef9627a
Fix potentially incorrect override
2020-12-02 10:54:26 +09:00
2840405112
Volume should be 0 by default
2020-12-01 18:14:14 +09:00
6b4a6c12c8
Fix bad equality comparer implementations
2020-12-01 18:13:53 +09:00
17560aeeea
Volume should be 0 by default
2020-12-01 18:09:28 +09:00
dda4d76d72
Fix bad equality comparer implementations
2020-12-01 18:09:21 +09:00
4900589af4
Remove unused method
2020-12-01 17:02:45 +09:00
2bb7484608
Merge branch 'immutable-hit-samples' into hit-sample-pooling
2020-12-01 16:05:28 +09:00
199710b941
Implement equality comparers for HitSampleInfo
2020-12-01 16:04:08 +09:00
5760e1c1fc
Make HitSampleInfo immutable
2020-12-01 15:37:51 +09:00
51741c4791
Merge branch 'master' into hit-sample-pooling
2020-11-30 22:25:28 +09:00
4bbeb9ebd4
Merge branch 'master' into hit-sample-pooling
2020-11-30 18:31:58 +09:00
