ed29646291
Remove IApplicableToDifficulty.ReadFromDifficulty
...
This was added specifically for `ModDifficultyAdjust`, but turned out to
be more of a headache than we expected. We have since removed usage and
would hope that this is not required by any other mods.
Opting for complete removal rather than obsoletion, as we discovered
this was already broken in multiple cases, with fixes being quite
logically complex.
If you happen to be a ruleset developer relying on this, open an issue
and we'll talk you through a better approach (or check what
`ModDifficultyAdjust` is doing now for an example).
2021-07-14 12:32:16 +09:00
48d5a3f94f
Merge pull request #13866 from frenzibyte/remove-duplicates
...
Reference `OverlayColourProvider` static colours in `OsuColour`'s definitions xmldocs
2021-07-14 12:06:47 +09:00
80636be767
Link Lime1 and Orange1 to their OverlayColourProvider's alternative
2021-07-14 03:22:00 +03:00
b4961cd12e
Revert "Remove duplicated colour definitions"
...
This reverts commit 9869986c59
2021-07-14 03:18:13 +03:00
9bec53bfa8
Implement osu!-side popover
2021-07-14 01:05:06 +02:00
b183b1e3dd
Merge pull request #13688 from Henry-YSLin/osu-random-mod-improvements
...
Improve osu random mod
2021-07-13 22:17:55 +09:00
94dc25837f
Merge branch 'master' into osu-random-mod-improvements
2021-07-13 20:39:23 +08:00
e7b78b1ea5
Adjust transform logic to hopefully be a bit easier to parse
2021-07-13 20:26:05 +09:00
8d82412b39
Merge pull request #13851 from gagahpangeran/autolink-md
...
Add autolink support in osu markdown container
2021-07-13 19:40:53 +09:00
4314946e10
Reorganise functions to order more logically (hitcircle before slider methods)
2021-07-13 19:37:17 +09:00
6b663037e4
Use switch for pattern matching
2021-07-13 19:37:02 +09:00
db8ffc6316
Merge branch 'master' into osu-random-mod-improvements
2021-07-13 19:31:37 +09:00
2436ebb6d3
Merge pull request #13874 from Naxesss/short-object-checks
...
Add object duration checks
2021-07-13 19:01:02 +09:00
9e1f929d52
Merge pull request #13873 from peppy/fix-match-screen-buttons-no-user
...
Fix multiplayer screen buttons showing no text when local user not available
2021-07-13 19:00:00 +09:00
4ce96109b7
Merge branch 'master' into fix-match-screen-buttons-no-user
2021-07-13 18:20:23 +09:00
0557761e51
Merge pull request #13862 from peppy/fix-multiplayer-create-game-failure-crash
...
Fix crash when multiplayer server join fails during game creation
2021-07-13 18:00:47 +09:00
e791669c40
Fix multiplayer screen buttons showing no text when local user not available
2021-07-13 17:59:58 +09:00
80e33065c6
Merge pull request #13872 from peppy/fix-multiplayer-exit-blocking
...
Fix disconnected-from-server multiplayer exit sequence being blocked by confirmation dialog
2021-07-13 17:57:43 +09:00
3a5912e35e
Add new checks to verifiers
2021-07-13 10:53:25 +02:00
53c0298b5e
Add too short spinners check and tests
2021-07-13 10:51:40 +02:00
fec9448301
Add too short sliders check and tests
2021-07-13 10:50:41 +02:00
6da2a3d51f
Add zero-length objects check and tests
2021-07-13 10:50:11 +02:00
28ff92e34e
Add test
2021-07-13 17:31:28 +09:00
60e17fc2b7
Fix disconnected-from-server multiplayer exit sequence being blocked by confirmation dialog
2021-07-13 17:12:35 +09:00
1c69da09d3
Merge branch 'master' into autolink-md
2021-07-13 15:04:36 +07:00
481e4dedb0
Move PopoverContainer to OsuGameBase
2021-07-13 16:51:31 +09:00
6409a518db
Focus password text box on popover display
2021-07-13 16:35:37 +09:00
5cffaf4d3b
Add extra explanatory comment to avoid any confusion
2021-07-13 14:34:56 +09:00
c7c691078a
Merge branch 'master' into fix-multiplayer-create-game-failure-crash
2021-07-13 14:34:42 +09:00
5a2667ae89
Merge branch 'master' into add-password-support
2021-07-13 14:27:59 +09:00
125bd36ab1
Send password in request ctor directly
2021-07-13 14:27:07 +09:00
35b5f0462c
Merge branch 'master' into add-password-support
2021-07-13 14:26:56 +09:00
e70744ee37
Merge pull request #13870 from bdach/fix-difficulty-bindable-bind-order
...
Fix reset to default logic failing for difficulty adjust mod
2021-07-13 14:12:22 +09:00
35841fa4f7
Merge branch 'master' into fix-difficulty-bindable-bind-order
2021-07-13 13:42:53 +09:00
5cff379cd9
Merge pull request #13860 from smoogipoo/fix-bindable-ctor
...
Fix DifficultyBindable not binding correctly and not having default ctor
2021-07-13 13:42:44 +09:00
5af2190246
Merge branch 'master' into fix-bindable-ctor
2021-07-13 12:46:01 +09:00
ac15dae930
Update framework
2021-07-13 12:35:25 +09:00
351a46b379
Merge pull request #13823 from ekrctb/catch-editor-tests
...
Add some tests for catch editor blueprints
2021-07-13 08:27:41 +09:00
ba5d884ab0
Merge pull request #13856 from peppy/fix-line-break
...
Fix one new incorrect formatting inspection from EAP6
2021-07-13 07:46:39 +09:00
cce4a4dc31
Fix incorrect value copy order in BindTo()
2021-07-12 22:27:36 +02:00
f3fe472a33
Add failing test case for reset to defaults
2021-07-12 22:25:21 +02:00
821c1b5335
Update hue of green colour scheme
2021-07-12 19:11:40 +03:00
62a00a82de
Revert completely irrelevant changes
...
This reverts commit b2b966463a
2021-07-12 19:11:28 +03:00
b2b966463a
Update hue of green colour scheme
2021-07-12 19:05:36 +03:00
c96a76df67
Update specified link
2021-07-12 18:21:10 +03:00
1437772711
Update hue of orange colour scheme
2021-07-12 18:11:51 +03:00
9869986c59
Remove duplicated colour definitions
2021-07-12 17:55:29 +03:00
1deaefacb7
Add "basic" lime colour theme
2021-07-12 17:53:15 +03:00
c6bd58ea4b
Exit match sub screen when a room goes away
...
Closes #13847 .
I think we can probably get some test coverage of this if required, but
needs a bit of thought (basically an error needs to be thrown during the
multiplayer client portion of the join procedure, after `CurrentRoom` is
non-null but before the join completes).
Manual testing on password branch (#13861 ) is possible since it
currently errors due to missing method on the live/dev servers.
- Create game, which will fail with `MethodNotExists`.
- Note the fields on the settings screen are emptied.
- Fill fields again and press create game (crash).
2021-07-12 19:20:41 +09:00
4dea2d9778
Dismiss popovers on returning to lounge
2021-07-12 18:54:17 +09:00
