Commit Graph

14628 Commits

Author SHA1 Message Date
092d16bb64 Dont use binding to set disabled value 2019-10-29 23:43:16 +03:00
30d9b21b86 Condition simplification 2019-10-29 21:57:20 +03:00
e287dae64b Fix VotePill can be activated by the comment sender 2019-10-29 21:25:48 +03:00
f4c4523034 Merge branch 'update-framework' into fix-chat-scroll-to-bottom 2019-10-29 18:17:41 +09:00
342dfc26d2 Merge remote-tracking branch 'upstream/master' into fix-chat-scroll-to-bottom 2019-10-29 18:17:38 +09:00
3f192ca915 Fix song progress not displaying correctly (#6640)
Fix song progress not displaying correctly

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2019-10-29 18:16:54 +09:00
e3a1613d2a Fix PlayerSettingsOverlay being shown by default (#6641)
Fix PlayerSettingsOverlay being shown by default
2019-10-29 18:16:33 +09:00
89d3f461e0 Fix download tracking components getting stuck on import failur… (#6639)
Fix download tracking components getting stuck on import failures
2019-10-29 18:16:23 +09:00
f4ae65c3e8 Merge branch 'master' into fix-song-progress-display 2019-10-29 18:06:58 +09:00
97c1a6e86b Update framework 2019-10-29 18:05:32 +09:00
f0f58c22d3 Merge branch 'master' into labelled-component-bindables 2019-10-29 16:32:57 +09:00
09a6d1184a Tidy up order of scroll changes 2019-10-29 14:33:05 +09:00
d1c6e3f620 Add test for scroll to end when max history is exceeded 2019-10-29 14:32:52 +09:00
c25a243d5b Merge branch 'master' into fix-triangles-performance 2019-10-29 13:31:33 +09:00
e93e9067a1 Fix beatmap carousel sorting instability (#6630)
Fix beatmap carousel sorting instability
2019-10-29 01:19:42 +09:00
a4a57eec54 Fix game-wide performance drop when triangles intro is used 2019-10-29 01:09:49 +09:00
c181edaedf Replace manual comparer implementation
Replace manually-implemented CriteriaComparer with a call to
Comparer<T>.Create() to decrease verbosity.
2019-10-28 15:07:36 +01:00
46b44f4f99 Fix PlayerSettingsOverlay being shown by default 2019-10-28 18:37:58 +09:00
16e33e8bc7 Fix song progress not displaying correctly 2019-10-28 18:34:58 +09:00
cf3ed42bfc Fix download tracking components getting stuck on import failures 2019-10-28 17:41:42 +09:00
08040adfad Expose Current bindable in LabelledComponents
Adds a `LabelledDrawable` class for usages where bindables are not present.
2019-10-28 16:24:28 +09:00
66b0004448 Remove unused logger provider class 2019-10-28 12:02:58 +09:00
c8d3dd0e5a Make carousel item sorting stable
Migrate beatmap carousel item sorting from List<T>.Sort()
to IEnumerable<T>.OrderBy(), as the second variant is documented to be
a stable sorting algorithm. This allows for eliminating unnecessary
movement of carousel items occurring whenever any set of items is tied
when changing sorting criteria.
2019-10-27 23:14:14 +01:00
676460019d Merge branch 'master' into equivalent-to 2019-10-27 11:51:05 +09:00
814b520e5e Avoid potential mis-cast in comparison 2019-10-27 11:35:45 +09:00
194e501f86 Merge branch 'master' into snapping-refactor 2019-10-26 14:20:08 +09:00
e39016bf01 Fix known non-nulls 2019-10-25 20:04:27 +09:00
e2f2638212 Replace local Equatable implementations with abstract EquivalentTo 2019-10-25 19:44:28 +09:00
c2f6cd9c24 Merge branch 'master' into comments-vote-pill 2019-10-25 19:19:44 +09:00
c9505f89dd Merge branch 'master' into markdown-inline-links 2019-10-25 18:52:11 +09:00
3692846367 Merge branch 'master' into snapping-refactor 2019-10-25 18:26:14 +09:00
ae011e8ee8 Fix distance snap grid test scenes 2019-10-25 17:25:46 +09:00
4ca6a5a0cc Interface the distance snap provider 2019-10-25 16:50:21 +09:00
607b4d874a Refactor flow of snapping through HitObjectComposer 2019-10-25 16:40:30 +09:00
e5b5d286fd Increase spacing to closer match the design 2019-10-25 12:48:34 +09:00
07f7944fc6 Fix DateTime display sizing on results screen 2019-10-25 12:22:19 +09:00
661dfbefaf Change containment check to overlap
Due to scenarios wherein a formatted link ended up as part of a larger
raw link after parsing, change the containment check to an overlap check
and add appropriate tests for these edge cases.
2019-10-25 00:42:58 +02:00
85769982a0 Refactor LoadingButton 2019-10-24 17:49:34 +03:00
4f79ac8095 Merge remote-tracking branch 'refs/remotes/ppy/master' into comments-vote-pill 2019-10-24 17:38:50 +03:00
0b3c7f28af Merge branch 'master' into fix-dragbox-first-frame 2019-10-24 23:01:32 +09:00
fa3350ce2d Refactor blueprint movement and selection events (#6588)
Refactor blueprint movement and selection events
2019-10-24 22:58:03 +09:00
cbd99cc767 Resolve link-in-link edge case
Testing with #6542 surfaced a crash scenario, caused by formatted links
that had URLs in the display text, for example

    [mean example - https://osu.ppy.sh](https://osu.ppy.sh)

In that case the outer Markdown link would get picked up once, and then
reduced to the link text when looking for other links, leading to it
being picked up again the second time when the raw link is found.

Add a check in the raw link parsing path that ensures that the found
URL is not a part of a bigger, pre-existing link.
2019-10-24 15:52:55 +02:00
24b7160522 Add support for parsing Markdown inline links
Extend the Markdown parsing regex to allow parsing so-called inline
links. Within the parenthesis () part of the Markdown URL syntax,
introduce a new capturing group:

    (
      \s+              // whitespace between actual URL and inline title
      (?<title>        // start of "title" named group
        ""             // opening double quote (doubled inside @ string)
        (
          [^""]        // any character but a double quote
          |            // or
          (?<=\\)      // the next character should be preceded by a \
          ""           // a double quote
        )*             // zero or more times
        ""             // closing double quote
      )
    )?                 // the whole group is optional

This allows for parsing the inline links as-provided by web. Correctness
is displayed by the passing tests.
2019-10-24 15:52:55 +02:00
a969914d6e Mention coordinate space 2019-10-24 18:24:22 +09:00
d83b9ef0e4 Rename grid snapping methods 2019-10-24 18:18:04 +09:00
f45f17339c Implement slider path distance snapping 2019-10-24 18:17:30 +09:00
7a71352684 Fix drag box being positioned incorrectly for 1 frame 2019-10-24 17:22:14 +09:00
fb88001c0e Reorder blueprint addition/removal + add regions 2019-10-24 16:53:34 +09:00
45bd91f63f Add special cases for click-selection 2019-10-24 16:14:29 +09:00
8e4a21bee7 Separate out mouse down/click/up handling 2019-10-24 15:58:22 +09:00