Commit Graph

4139 Commits

Author SHA1 Message Date
074d2a7a3a chore(osu.Game): provide ordering index for HitResult 2022-09-05 02:01:44 +09:00
5f0832ead7 refactor(osu.Game): separate OsuColour.ForHitResult by usage 2022-09-05 01:58:57 +09:00
6a35b233e5 Merge branch 'master' into remove-dispose-updates 2022-09-01 23:03:19 +09:00
e3e204001e Merge pull request #19907 from peppy/ruleset-api-versioning
Add ruleset API versioning
2022-08-29 18:50:01 +09:00
9b830d063f Merge pull request #20010 from smoogipoo/scoreprocessor-no-rewrite-statistics
Don't include misses in failed score statistics
2022-08-29 17:07:13 +09:00
105aa01e7d Update usages of RemoveInternal 2022-08-29 15:57:40 +09:00
a215d009fe Update Remove/RemoveRange/RemoveAll calls in line with framework changes 2022-08-29 15:57:40 +09:00
81ac0daba8 Update xmldoc 2022-08-29 15:51:12 +09:00
b2e80ca7f0 Don't include misses in failed score statistics 2022-08-29 15:27:19 +09:00
90b9c02ac6 Remove "internal" identifier as unnecessary 2022-08-29 14:01:15 +09:00
c0b13c7e1f Refactor ScoreProcessor ComputeScore() methods 2022-08-29 13:51:10 +09:00
91e044542d Merge pull request #19828 from peppy/no-gameplay-clock-gameplay-offset
Introduce `FramedBeatmapClock` (and use in gameplay flow)
2022-08-26 20:21:34 +09:00
9bca7223f6 Adjust xmldoc to better explain score contribution 2022-08-25 17:16:30 +09:00
e2e10a8f26 Add some explanatory comments to conditions 2022-08-25 17:14:53 +09:00
3a17c6df08 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-25 16:24:55 +09:00
eb57ea76ab Merge branch 'master' into legacy-combo-increase 2022-08-25 09:46:12 +03:00
e7cbb6c63d Fix test failures/nullability 2022-08-24 19:53:16 +09:00
c9ff39f8c3 Add HitResult.LegacyComboIncrease 2022-08-24 19:46:41 +09:00
5ec95c9269 Update ScoreProcessor to make use of MaximumStatistics 2022-08-24 19:46:41 +09:00
f70af779a4 Add maximum statistics to ScoreInfo/SoloScoreInfo 2022-08-24 17:28:41 +09:00
ec61a94dc9 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-23 17:36:06 +09:00
758a554180 Add basic check for correct ruleset API version 2022-08-22 16:35:08 +09:00
f5710d8000 Add ruleset API versioning 2022-08-22 16:35:08 +09:00
3fb3a18e68 Merge pull request #19906 from peppy/fix-editor-crash-mobile
Fix editor crashing on mobile releases
2022-08-22 16:31:19 +09:00
058d67f8e8 Merge pull request #19695 from naoei/ruleset-localization
Change most ruleset-accessible string types to Localisable strings
2022-08-22 16:13:23 +09:00
19bba143ee Fix editor crashing on mobile releases 2022-08-22 15:57:24 +09:00
d199b3b100 Update GetVariantName to also support localisation 2022-08-22 14:51:00 +09:00
9d31f61ca9 Don't throw when a ruleset type is completely missing 2022-08-22 14:35:44 +09:00
Nao
189a407cb1 Merge branch 'master' into ruleset-localization 2022-08-20 21:39:10 -04:00
2c6fd1ec6e Fix `GameplayClockContainer potentially resetting external seeks 2022-08-18 18:54:10 +09:00
b0a740071e Centralise logging of failed ruleset loads 2022-08-18 16:14:38 +09:00
e0edaf996f Test ruleset compatibility during initial startup to avoid runtime errors
As we continue to break the ruleset API, it makes more sense to
proactively check known changes and bail early during ruleset loading to
avoid a user experiencing a crash at a random point during execution.

This is a RFC and needs to be tested against known broken rulesets.
There might be some other calls we want to add in addition to the ones
I've listed.
2022-08-18 16:03:38 +09:00
43442dbf65 Merge branch 'even-less-gameplay-clock' into even-nicer-frame-stability-clock 2022-08-15 20:22:30 +09:00
87760bbc06 Fix IsCatchingUp not being in correct state 2022-08-15 20:17:48 +09:00
1fc3d005c0 Seal FrameStabilityContainer
No one should ever derive from this class. It is already too complex.
2022-08-15 19:31:02 +09:00
fff2b57905 Tidy up and document FrameStabilityContainer 2022-08-15 19:28:12 +09:00
9bc2e91de0 Fix incorrect handling of reference clocks when no parent IGameplayClock is available 2022-08-15 19:19:19 +09:00
828b6f2c30 Remove unnecessary setClock shenanigans 2022-08-15 19:19:19 +09:00
27569e2ed5 Remove FrameStableClock (and redirect usages to FrameStabilityContainer) 2022-08-15 19:19:19 +09:00
c8764cb333 Move all usage of GameplayClock to IGameplayClock 2022-08-15 18:30:53 +09:00
95c1b488a7 Add non-null assertion to FrameStabilityContainer 2022-08-15 18:08:49 +09:00
Nao
c940f5abcb Merge branch 'master' into ruleset-localization 2022-08-14 15:17:44 -04:00
45e9eda9e7 Localise hit result name 2022-08-14 14:57:02 -04:00
9d1b0b5836 Revert sealing 2022-08-12 22:32:27 +09:00
e5e9841652 Apply multiple other mod debuffs as decided in pull request discussion 2022-08-12 18:58:09 +09:00
ac4213ecee Adjust relax mod multiplayer to 0.5x
Has previously been discussed internally. Probably good to get this out
before the next full reprocess of scores server-side.

The multiplier here was @smoogipoo's suggested value. I'd be willing to
go lower if this is seen at too high, but it should be a round number to
make it easy for users to understand the max score available to them.
2022-08-12 12:30:13 +09:00
1e356f6137 Revert localisation for GetDisplayNameForHitResult
Came across an issue where `LeaderboardScoreTooltip` attempts to capitalize all letters for the `displayName`.

Unsure if I should completely ignore it and localise it anyway.
2022-08-10 16:03:59 -04:00
60dae70a18 Change mod description type to LocalisableString 2022-08-10 15:54:48 -04:00
8cb2e11766 Change most ruleset-accessible string types to Localisable strings 2022-08-10 15:51:11 -04:00
f9c6dc314b Merge pull request #19678 from peppy/fix-file-comparisons-many-places
Fix audio track not correctly advancing when changing between certain beatmaps
2022-08-10 20:38:14 +09:00