Commit Graph

38364 Commits

Author SHA1 Message Date
63d48f0c7d Fix incorrect unicode/romanised string order 2021-02-25 14:06:29 +09:00
a362382d38 Add back more correct null checks 2021-02-25 14:06:21 +09:00
67773c42ef Merge pull request #11888 from H2n9/modtimeramp-new-behaviour 2021-02-25 14:01:57 +09:00
421b7877d4 Avoid mixing precision across time ramp bindables
Bears no functional difference, it's just a bit less of an eyesore.
2021-02-24 19:16:10 +01:00
73d6a3687e Change rate correction logic to be more explicit 2021-02-24 14:40:56 +00:00
3e2b21a9b4 Merge pull request #11892 from peppy/allow-collection-name-collisions
Fix crash on two collections existing with the same name
2021-02-24 23:08:05 +09:00
a7d10630e0 Merge pull request #11893 from peppy/fix-request-queue-reference-holding
Fix requests being indefinitely queued when user is offline
2021-02-24 23:07:02 +09:00
fa6d797adf Remove redundant prefix 2021-02-24 20:30:17 +09:00
9aeb4af95c Merge pull request #11864 from smoogipoo/fix-selecting-incompatible-freemods 2021-02-24 20:03:31 +09:00
9ed8d902f7 Fix requests being indefinitely queued when user is offline 2021-02-24 19:57:42 +09:00
5dc0aefb2b Cancel request on leaving results screen 2021-02-24 19:54:52 +09:00
0c202e0777 Merge branch 'master' into fix-selecting-incompatible-freemods 2021-02-24 19:24:04 +09:00
6a515391f0 Merge pull request #11891 from smoogipoo/more-incompatible-mods 2021-02-24 19:11:09 +09:00
6e6fb31c05 Add test coverage 2021-02-24 18:49:16 +09:00
165da32044 Fix dropdown crash on collection name collisions 2021-02-24 18:41:42 +09:00
c0f21c8cbe Merge branch 'master' into fix-selecting-incompatible-freemods 2021-02-24 15:10:48 +09:00
6b6811063b Make ExpandDirection abstract 2021-02-24 15:05:12 +09:00
0b44d2483b Make some properties virtual
I think they were intended to be this way from the beginning.
2021-02-24 15:03:41 +09:00
14160b897e Fix references to ModSuddenDeath 2021-02-24 14:44:53 +09:00
30a58691f0 Make SD and PF incompatible with each other 2021-02-24 14:34:37 +09:00
dd702ccfd2 Make mania FI/HD incompatible with each other 2021-02-24 14:34:37 +09:00
a229c3a0f4 Merge pull request #11882 from peppy/fix-import-collections-twice-crash
Fix importing collections twice from stable causing a hard crash
2021-02-24 14:31:54 +09:00
e76c6b1019 Merge pull request #11880 from peppy/disable-all-mouse-buttons
When disable mouse buttons during gameplay is selected, disable more globally
2021-02-24 14:30:38 +09:00
de48b7c8c8 Merge branch 'master' into fix-import-collections-twice-crash 2021-02-24 13:25:31 +09:00
90e515aadd Merge branch 'master' into disable-all-mouse-buttons 2021-02-24 13:25:28 +09:00
2e730cdde7 Merge pull request #11867 from peppy/add-quick-run-test-beatmap
Fix test failures due to beatmap taking too long to complete autoplay/replay
2021-02-24 13:25:22 +09:00
cfea4c7d4d Merge pull request #11881 from peppy/disable-hub-connections-on-ios
Disable multiplayer/spectator on iOS until it can be supported again
2021-02-24 13:09:03 +09:00
59e6bad0b9 Remove unnecessary interpolated string specification 2021-02-24 12:46:37 +09:00
7000132d03 Specify full filename inline for quick beatmap 2021-02-24 12:45:00 +09:00
e1f71038e3 Remove unncessary action 2021-02-24 12:13:55 +09:00
71182347d6 Also add a notifiation when trying to enter the multiplayer screen
Turns out the only check required to get into this screen was that the
API was online, which it always is even if the multiplayer component
isn't.

This provides a better end-user experience.
2021-02-24 11:30:14 +09:00
f6d3cd6413 Change SamplePlaybackWithRateMods to use rate calulated from the sample
Replace hardcoded numbers
2021-02-23 21:25:59 +00:00
6dc0cf5ea9 Merge branch 'master' into fix-import-collections-twice-crash 2021-02-23 22:14:25 +01:00
877e19421b Refactor movement while scaling 2021-02-23 21:02:00 +01:00
2a4139a207 Refactor isQuadInBounds 2021-02-23 21:02:00 +01:00
71b30bdbbb Adjust tuple usage 2021-02-23 21:02:00 +01:00
3491021f72 Move moveSelection into HandleMovement 2021-02-23 21:02:00 +01:00
dbde47fe94 Fix test failure 2021-02-23 19:43:04 +00:00
7394c62cc8 Make ModTimeRamp and ModRateAdjust incompatible 2021-02-23 18:10:03 +00:00
a6e840634b Adjust scrubbing behaviour to allow dragging through rate values 2021-02-23 15:52:53 +00:00
f45cedeb85 Adjust initial and final rate ranges and prevent them from overlapping 2021-02-23 15:38:09 +00:00
e679a1916f Merge pull request #11833 from frenzibyte/fix-pofl-on-cooldown
Keep pausing gameplay on focus loss if cannot on first attempt
2021-02-24 00:15:58 +09:00
c514233141 Fix importing collections twice from stable causing a hard crash
Somehow a bindable equality check failure got through review. Not sure
if there's some way to protect against this going forward, but we may
want to.
2021-02-23 15:57:43 +09:00
664d243003 Disable multiplayer/spectator on iOS until it can be supported again 2021-02-23 15:22:46 +09:00
ec4b770cba Remove unused using statement 2021-02-23 14:56:03 +09:00
672fd3f9d2 When disable mouse buttons during gameplay is selected, disable more globally
Until now the disable setting would only apply to left/right buttons,
and only in gameplay. This change will cause any global actions bound to
mouse buttons to also not work during gameplay.

Closes #11879.
2021-02-23 14:37:46 +09:00
996c0897d1 Seek via GameplayClockContainer for better reliability 2021-02-23 13:40:21 +09:00
6a5c6febc5 Add inline comment explaining the retry loop 2021-02-23 13:23:32 +09:00
66f86bdee5 Merge pull request #11868 from peppy/fix-playlist-test-delay-when-headless 2021-02-22 23:33:03 +01:00
15e250622b Merge branch 'master' into fix-playlist-test-delay-when-headless 2021-02-22 22:48:12 +01:00