Commit Graph

36 Commits

Author SHA1 Message Date
778d2a71b4 Remove Task from the inner-most Import method in RealmArchiveModelImporter
One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.
2022-01-25 15:30:29 +09:00
8e79898e26 Fix a couple of minor issues with TestSceneBeatmapRecommendations 2022-01-12 17:49:10 +09:00
00177a3ae1 Update usages to new naming 2022-01-06 22:54:43 +09:00
73b40e6833 Replace usage of .Result with .WaitSafelyForResult 2022-01-04 11:51:41 +09:00
0fe27cc8a1 Replace one more usage 2021-11-24 18:29:33 +09:00
74b6c33fab Merge pull request #15778 from peppy/ruleset-info-id-usage
Update usages of `RulesetInfo.ID` to use `OnlineID` instead
2021-11-24 16:55:28 +09:00
f283770f34 Update mock RulesetInfo usage to set OnlineID instead of ID 2021-11-24 15:50:26 +09:00
44c34ca7b2 Revert changes causing BeatmapSet.Metadata to be expectedly null in some tests 2021-11-24 14:52:08 +09:00
8c60f37508 Fix cases of dynamically assigning Beatmaps to BeatmapSetInfo using list assignment 2021-11-24 13:27:37 +09:00
4856180912 Use new helper method 2021-11-15 19:19:53 +09:00
86b8fd3720 Fix TestSceneBeatmapRecommendations testing with an online ID of 0 2021-11-15 19:19:53 +09:00
692e846acd Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface 2021-11-12 17:52:44 +09:00
6a098a8634 Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface 2021-11-12 17:46:24 +09:00
51a353e12d Rename BeatmapInfo.Version to DifficultyName to match underlying interface 2021-11-11 17:20:53 +09:00
ebe58cee11 Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface 2021-11-11 17:19:46 +09:00
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
a2e61883e3 Initial push to use ILive in import process 2021-09-30 22:55:25 +09:00
2758a83d55 Fix TestSettingsMigration's usage of RecycleLocalStorage 2021-08-18 16:39:10 +09:00
aeff9bd853 Add return bool to HandleRequest to better trigger failures 2021-03-23 18:17:29 +09:00
a16c0641b2 Revert EF Core to version 2.2
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
2021-03-21 11:05:15 +01:00
fce21f23d6 Add comments marking workarounds required for EFcore 5 2021-03-15 13:29:26 +09:00
c6c616f244 Actualize tests 2021-03-11 21:02:40 +03:00
c6be969e33 Remove unnecessary resolved recommender in test 2020-12-22 14:42:12 +09:00
e792f07084 Add test for recommending current ruleset 2020-12-03 20:07:42 +02:00
48dad61a46 Apply review suggestions 2020-12-03 19:44:12 +02:00
07db977af5 Remove no longer necessary force calculation
Is no longer necessary because recommender uses bindable state value changes, compared to when the test was written, and runs the state change once on load
2020-11-21 14:36:43 +02:00
d30e4061cc Add clarifying comment about pp choice 2020-05-01 19:46:49 +03:00
3cf60e6e00 Add failing test 2020-05-01 19:43:18 +03:00
2913a81835 Improve test code quality & safety 2020-05-01 16:59:45 +02:00
f68a7401b9 Fix comment 2020-04-25 10:37:18 +03:00
e65acc3401 Other review suggestions 2020-04-25 10:36:19 +03:00
e906ec4d92 Fix typo 2020-04-25 10:25:07 +03:00
52416ea90a Use GetRuleset 2020-04-25 10:22:19 +03:00
ce47b7ca93 Unnest in SetUpSteps 2020-04-25 10:21:01 +03:00
90fa58b3b6 More testing 2020-04-17 19:57:39 +03:00
da9bd74e2e Very basic testing 2020-04-15 20:19:17 +03:00