cd31cff8cd
Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
...
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.
This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
5757eb7529
Update a few more instances of 0.96f scale constants
2023-05-03 18:20:12 +09:00
88135a3be8
Merge pull request #23384 from peppy/fix-incorrect-transform-thread
...
Fix potentially incorrect thread access in `OsuTabControlCheckbox`
2023-05-03 10:37:27 +02:00
ff28d941b3
Merge pull request #23385 from Joehuu/scroll-back-button-block-hover
...
Fix overlay scroll back button not absorbing hover from behind
2023-05-03 16:28:05 +09:00
de1b28bcb2
Fix incorrect initial state of checkbox
...
This only ever barely used to work without the `(..., true)`
in `master` because of haphazard operation ordering.
2023-05-03 09:27:23 +02:00
5f781bd6de
Move callback to LoadComplete()
...
Is the more correct place for `BindValueChanged()` callbacks.
2023-05-03 09:26:54 +02:00
453143813f
Extend input handling of osu! logo to full border area
...
This is the easiest way to make this happen. It does mean the pink area
is being drawn behind the white border, but I haven't found a scenario
where this is noticeable.
Closes #4217 .
2023-05-03 14:57:57 +09:00
1c74f6e8ea
Fix regressed button hover fade in
2023-05-02 22:54:42 -07:00
bede1292de
Fix overlay scroll back button not absorbing hover from behind
2023-05-02 22:40:37 -07:00
a3efae3690
Fix potentially incorrect thread access in OsuTabControlCheckbox
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736829 .
2023-05-03 14:33:32 +09:00
6b017ac05f
Merge pull request #23308 from OliBomby/sample-control-points
...
Remove SampleControlPoint and DifficultyControlPoint from HitObject
2023-05-03 14:21:51 +09:00
f930c4bd0a
Move struct to bottom of file
2023-05-03 13:33:31 +09:00
48fd99818e
Split out default and sample application
2023-05-03 13:30:45 +09:00
cca15f930c
Refactor applyLegacyInfoAndDefaults for legibility
2023-05-03 13:26:50 +09:00
588a4e6196
Move pragma disable to top of LegacyBeatmapDecoder
...
Makes more sense as it's used multiple times in the class.
2023-05-03 13:19:14 +09:00
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
ec8362c6fc
Merge pull request #23367 from peppy/fix-uo-tooltip
...
Fix slider bar tooltips potentially showing negative zero
2023-05-02 18:03:09 +02:00
48dd42407b
Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference
...
Fix `BeatmapAttributeText` not supporting unicode artist/title
2023-05-02 17:32:55 +02:00
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
414b80d44e
Change flashlight depth in a more standard way
2023-05-02 17:00:54 +09:00
b2b9f2a036
Merge branch 'master' into bubble_mod_implementation_clean
2023-05-02 16:59:55 +09:00
2e018c8b06
Fix comment 2 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2023-05-02 08:41:47 +02:00
c2ad8c2320
Fix comment 1 osu.Game/Rulesets/Objects/Types/IHasGenerateTicks.cs
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2023-05-02 08:41:30 +02:00
67f83f246b
Add more padding around playfield in editor to avoid overlap with tool areas
...
Closes #23130 .
2023-05-02 15:37:02 +09:00
4a97c2c105
Merge pull request #23038 from cdwcgt/scale-background-dim
...
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
ce4a6c38a0
Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
...
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
8a536c1cdb
Fix non-block namespace usage
2023-05-02 15:09:24 +09:00
1e4a628cb1
Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
...
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
e3c384c6b5
Merge branch 'master' into sample-control-points
2023-05-02 14:38:39 +09:00
57f48e0703
Start colour black to ensure initial appear transition doesn't look silly
2023-05-02 14:33:57 +09:00
ab4f66fad3
Minor readability refactors
2023-05-02 14:31:39 +09:00
7a840e1d82
Remove unnecessary TransferValue spec
2023-05-02 14:29:26 +09:00
7efaa299bd
Merge branch 'master' into scale-background-dim
2023-05-02 14:24:54 +09:00
736be6a73b
Refactor slightly for readability
2023-05-02 14:11:16 +09:00
ad40099e32
Ensure negative sign is only applied when the post-rounded result is negative
2023-05-02 14:00:52 +09:00
37a5dde859
Fix BeatmapAttributeText not supporting unicode artist/title
2023-05-02 13:47:49 +09:00
e808e7316b
Mark delegate value unused and add comment to avoid future regression
2023-05-02 13:29:30 +09:00
63890ef6fe
Fix audio offset tooltip potentially showing "-0 ms"
...
Closes https://github.com/ppy/osu/issues/23339 .
2023-05-02 13:24:22 +09:00
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
5da78098ad
Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id
...
Reset online ID on locally modifying beatmap
2023-05-02 12:41:23 +09:00
436ebdcfcb
Fix beatmap leaderboard test failure
...
Because the online info reset (which includes online ID reset) was
happening after encoding,
`TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
started failing, as the hash no longer matched expectations after the
first save of the map.
2023-05-01 19:44:15 +02:00
cf5211aec9
Enable current distance snap when exactly on a hit object
2023-05-01 19:22:52 +02:00
f470b2c9cc
Always reset online info when saving local beatmap
2023-05-01 18:17:45 +02:00
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3e72f103c17
2023-05-01 18:17:35 +02:00
8c21fddb5e
remove all redundancies from encoded control points
2023-05-01 16:53:38 +02:00
1dc34ee25d
fix infinite repeat count when adjusting length of 0 length slider
2023-05-01 15:48:54 +02:00
8302bb1f37
dont encode custom sample bank for objects without legacy samples
2023-05-01 14:56:29 +02:00
27cfadca16
add sample info to Banana and SpinnerBonusTick
2023-05-01 14:54:06 +02:00
4d52ce769b
Revert SaveState() calling on initialization
2023-05-01 12:53:58 +02:00
